Patchwork [U-Boot] mpc8xxx: Fix "DRAM" message formatting

login
register
mail settings
Submitter Kyle Moffett
Date Dec. 16, 2011, 2:14 a.m.
Message ID <1324001689-15226-1-git-send-email-Kyle.D.Moffett@boeing.com>
Download mbox | patch
Permalink /patch/131770/
State Changes Requested
Headers show

Comments

Kyle Moffett - Dec. 16, 2011, 2:14 a.m.
When the "Detected RDIMM [...]" message was added, it broke the
pretty-printing of the DRAM information during boot.

It used to look like this:
  DRAM:  2 GiB (DDR2, 64-bit, CL=4, ECC on)
         DDR Chip-Select Interleaving Mode: CS0+CS1

Right now, it looks like this:
  DRAM:  Detected RDIMM VL493T5663D-E6M
  2 GiB (DDR2, 64-bit, CL=4, ECC on)
         DDR Chip-Select Interleaving Mode: CS0+CS1

After this patch, it is:
  DRAM:  Detected RDIMM VL493T5663D-E6M
         2 GiB (DDR2, 64-bit, CL=4, ECC on)
         DDR Chip-Select Interleaving Mode: CS0+CS1

Signed-off-by: Kyle Moffett <Kyle.D.Moffett@boeing.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Kim Phillips <kim.phillips@freescale.com>
Cc: Andy Fleming <afleming@gmail.com>
Cc: Kumar Gala <kumar.gala@freescale.com>
---
 .../cpu/mpc8xxx/ddr/lc_common_dimm_params.c        |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Wolfgang Denk - Dec. 17, 2011, 8:12 p.m.
Dear Kyle Moffett,

In message <1324001689-15226-1-git-send-email-Kyle.D.Moffett@boeing.com> you wrote:
> When the "Detected RDIMM [...]" message was added, it broke the
> pretty-printing of the DRAM information during boot.
> 
> It used to look like this:
>   DRAM:  2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1
> 
> Right now, it looks like this:
>   DRAM:  Detected RDIMM VL493T5663D-E6M
>   2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1
> 
> After this patch, it is:
>   DRAM:  Detected RDIMM VL493T5663D-E6M
>          2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1

We discussed this before.

This outpout is too verbose.  It should read:

	DRAM:  2 GiB

And not more.  Any additional information should only be printed upon
explicit request from the user.

Thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c b/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
index 20c7db0..3f9104c 100644
--- a/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
+++ b/arch/powerpc/cpu/mpc8xxx/ddr/lc_common_dimm_params.c
@@ -209,11 +209,11 @@  compute_lowest_common_dimm_parameters(const dimm_params_t *dimm_params,
 		if (dimm_params[i].n_ranks) {
 			if (dimm_params[i].registered_dimm) {
 				temp1 = 1;
-				printf("Detected RDIMM %s\n",
+				printf("Detected RDIMM %s\n       ",
 					dimm_params[i].mpart);
 			} else {
 				temp2 = 1;
-				printf("Detected UDIMM %s\n",
+				printf("Detected UDIMM %s\n       ",
 					dimm_params[i].mpart);
 			}
 		}