| Message ID | a4423d670812100321qc93060evd0d3ae3f78418b29@mail.gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: "Alexander Beregalov" <a.beregalov@gmail.com> Date: Wed, 10 Dec 2008 14:21:46 +0300 > 2008/12/10 David Miller <davem@davemloft.net>: > > From: Alexey Dobriyan <adobriyan@gmail.com> > > Date: Tue, 9 Dec 2008 18:08:27 +0300 > > > >> On Tue, Dec 09, 2008 at 05:11:17PM +0300, Alexander Beregalov wrote: > >> > CC arch/ia64/hp/sim/simeth.o > >> > arch/ia64/hp/sim/simeth.c: In function 'simeth_probe1': > >> > arch/ia64/hp/sim/simeth.c:212: error: 'struct net_device' has no member named 'open' > >> > >> [PATCH] simeth: convert to net_device_ops > >> > >> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> > > > > This doesn't explain the build failure. > > > > Using ->open() and friends should work perfectly fine for drivers not > > yet converted to netdev_ops. The code protected by COMPAT_NET_DEV_OPS > > provides this, and we force that Kconfig option to always be on. > > > > I don't want to add this patch and just shrug off this build failure. > > If this build failures, we should be seeing 200 other drivers not > > build too. > > > > I suspect something is messed up with this person's kernel config > > or similar. > > > > Thanks for explanation. > Is it better? Good fix, except that your email client corrupted the patch by turning tab characters into spaces. I fixed this up and applied your patch. But please next time provide a proper Signed-off-by line too. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
arch/ia64/hp/sim/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/ia64/hp/sim/Kconfig b/arch/ia64/hp/sim/Kconfig index f92306b..8d513a8 100644 --- a/arch/ia64/hp/sim/Kconfig +++ b/arch/ia64/hp/sim/Kconfig @@ -4,6 +4,7 @@ menu "HP Simulator drivers" config HP_SIMETH bool "Simulated Ethernet " + depends on NET config HP_SIMSERIAL bool "Simulated serial driver support"