From patchwork Tue Dec 13 22:51:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 131205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "acsinet15.oracle.com", Issuer "Oracle SSL CA" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 95BC11007D3 for ; Wed, 14 Dec 2011 09:51:55 +1100 (EST) Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pBDMpoBL006736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Dec 2011 22:51:51 GMT Received: from oss.oracle.com (oss.oracle.com [141.146.12.120]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id pBDMpn5Z001172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 13 Dec 2011 22:51:50 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1RabCK-00060Y-PU; Tue, 13 Dec 2011 14:51:44 -0800 Received: from acsinet13.oracle.com ([141.146.126.235]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1RabCJ-00060R-Fm for fedfs-utils-devel@oss.oracle.com; Tue, 13 Dec 2011 14:51:43 -0800 Received: from mail-vx0-f171.google.com (mail-vx0-f171.google.com [209.85.220.171]) by acsinet13.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pBDMov1E021828 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL) for ; Tue, 13 Dec 2011 22:51:43 GMT Received: by mail-vx0-f171.google.com with SMTP id fo1so205521vcb.2 for ; Tue, 13 Dec 2011 14:51:43 -0800 (PST) Received: by 10.220.107.79 with SMTP id a15mr2981401vcp.61.1323816702936; Tue, 13 Dec 2011 14:51:42 -0800 (PST) Received: from degas.1015granger.net (adsl-99-26-161-222.dsl.sfldmi.sbcglobal.net. [99.26.161.222]) by mx.google.com with ESMTPS id jo9sm538934vdb.7.2011.12.13.14.51.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 13 Dec 2011 14:51:42 -0800 (PST) From: Chuck Lever To: fedfs-utils-devel@oss.oracle.com Date: Tue, 13 Dec 2011 17:51:41 -0500 Message-ID: <20111213225141.15402.32056.stgit@degas.1015granger.net> In-Reply-To: <20111213224842.15402.340.stgit@degas.1015granger.net> References: <20111213224842.15402.340.stgit@degas.1015granger.net> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Flow-Control-Info: class=ISPs ip=209.85.220.171 ct-class=G1 ct-vol1=0 ct-vol2=0 ct-vol3=0 ct-risk=0 ct-spam1=0 ct-spam2=0 ct-bulk=0 rcpts=1 size=853 Subject: [fedfs-utils] [PATCH 05/12] libnsdb: don't leak upon LDAP parse failure X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-CT-RefId: str=0001.0A090202.4EE7D707.0066:SCFSTAT1119972, ss=1, re=-4.000, fgs=0 X-Auth-Type: Internal IP From: Jim Meyering * src/libnsdb/fileserver.c (nsdb_resolve_fsn_parse_entry): When we fail to parse an LDAP entry, free just-allocated new->fl_dn and new. Spotted by coverity. Introduced by commit 0520ee72: "Initial commit," (March 29, 2011). Signed-off-by: Jim Meyering --- src/libnsdb/fileserver.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c index a7631e8..b22d83f 100644 --- a/src/libnsdb/fileserver.c +++ b/src/libnsdb/fileserver.c @@ -781,6 +781,8 @@ nsdb_resolve_fsn_parse_entry(LDAP *ld, LDAPMessage *entry, if (retval != FEDFS_OK) { xlog(D_CALL, "%s: parsing failed: %s", __func__, nsdb_display_fedfsstatus(retval)); + free(new->fl_dn); + free(new); return retval; }