From patchwork Tue Dec 13 22:51:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [05/12] libnsdb: don't leak upon LDAP parse failure Date: Tue, 13 Dec 2011 12:51:41 -0000 From: Chuck Lever X-Patchwork-Id: 131205 Message-Id: <20111213225141.15402.32056.stgit@degas.1015granger.net> To: fedfs-utils-devel@oss.oracle.com From: Jim Meyering * src/libnsdb/fileserver.c (nsdb_resolve_fsn_parse_entry): When we fail to parse an LDAP entry, free just-allocated new->fl_dn and new. Spotted by coverity. Introduced by commit 0520ee72: "Initial commit," (March 29, 2011). Signed-off-by: Jim Meyering --- src/libnsdb/fileserver.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c index a7631e8..b22d83f 100644 --- a/src/libnsdb/fileserver.c +++ b/src/libnsdb/fileserver.c @@ -781,6 +781,8 @@ nsdb_resolve_fsn_parse_entry(LDAP *ld, LDAPMessage *entry, if (retval != FEDFS_OK) { xlog(D_CALL, "%s: parsing failed: %s", __func__, nsdb_display_fedfsstatus(retval)); + free(new->fl_dn); + free(new); return retval; }