From patchwork Tue Dec 9 23:33:28 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Benedikt Gollatz X-Patchwork-Id: 13119 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id DC4F4DDF66 for ; Wed, 10 Dec 2008 11:01:09 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753652AbYLJABE (ORCPT ); Tue, 9 Dec 2008 19:01:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754044AbYLJABE (ORCPT ); Tue, 9 Dec 2008 19:01:04 -0500 Received: from 213-239-195-174.clients.your-server.de ([213.239.195.174]:49768 "EHLO mail.g4b.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbYLJABB (ORCPT ); Tue, 9 Dec 2008 19:01:01 -0500 X-Greylist: delayed 1648 seconds by postgrey-1.27 at vger.kernel.org; Tue, 09 Dec 2008 19:01:00 EST Received: from laforge-linux.localnet (unknown [IPv6:2001:6f8:11b2:1:221:e9ff:fedb:8691]) by mail.g4b.org (Postfix) with ESMTP id F17CB1D742AA for ; Wed, 10 Dec 2008 00:33:30 +0100 (CET) From: Benedikt Gollatz To: netdev@vger.kernel.org Subject: Minor bug in "ip addr" output Date: Wed, 10 Dec 2008 00:33:28 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.27.5-117.fc10.i686; KDE/4.1.3; i686; ; ) MIME-Version: 1.0 Content-Disposition: inline Message-Id: <200812100033.28850.ben@differentialschokolade.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is a minor problem in iproute2 regarding the output of "ip -6 addr". Preferred lifetimes of IPv6 prefixes are printed as unsigned integers even though they may become negative (for deprecated prefixes). As I've argued in , I think this is partly because of an inconsistency in the kernel APIs, but since nobody seemed interested, I guess it has to be dealt with by application developers. The following patch fixes the problem. --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/ip/ipaddress.c 2008-07-25 22:46:07.000000000 +0200 +++ b/ip/ipaddress.c 2008-12-08 03:29:27.000000000 +0100 @@ -360,4 +360,5 @@ struct ifaddrmsg *ifa = NLMSG_DATA(n); int len = n->nlmsg_len; + int deprecated = 0; struct rtattr * rta_tb[IFA_MAX+1]; char abuf[256]; @@ -489,4 +490,5 @@ if (ifa->ifa_flags&IFA_F_DEPRECATED) { ifa->ifa_flags &= ~IFA_F_DEPRECATED; + deprecated = 1; fprintf(fp, "deprecated "); } @@ -517,7 +519,12 @@ if (ci->ifa_prefered == INFINITY_LIFE_TIME) sprintf(buf+strlen(buf), " preferred_lft forever"); - else - sprintf(buf+strlen(buf), " preferred_lft %usec", - ci->ifa_prefered); + else { + if (deprecated) + sprintf(buf+strlen(buf), " preferred_lft %dsec", + ci->ifa_prefered); + else + sprintf(buf+strlen(buf), " preferred_lft %usec", + ci->ifa_prefered); + } fprintf(fp, " %s", buf); }