Patchwork P2P:Provision discovery from a known peer should check for PROBE_REQ_ONLY flag

login
register
mail settings
Submitter Neeraj Garg
Date Dec. 13, 2011, 12:28 p.m.
Message ID <2C2F1EBA8050E74EA81502D5740B4BD6BBBCADF568@SJEXCHCCR02.corp.ad.broadcom.com>
Download mbox | patch
Permalink /patch/131063/
State Accepted
Commit bfe3557a0790a036c75f5cd58a318f408a8d4ab8
Headers show

Comments

Neeraj Garg - Dec. 13, 2011, 12:28 p.m.
Provision discovery from a known peer should actually check for dev->flags & P2P_DEV_PROBE_REQ_ONLY. This is creating an issue of updating the listen frequency of peer with the PD request frame frequency. PD request frame will be sent by the peer on our local listen frequency. This patch fixes that error. Suggested check has already been implemented in the invitation req receive path.
Please let me know if the patch is OK.

Subject: [PATCH] [PATCH]P2P:Provision discovery from a known peer should check for PROBE_REQ_ONLY flag.
---
 src/p2p/p2p_pd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Jouni Malinen - Dec. 18, 2011, 3:44 p.m.
On Tue, Dec 13, 2011 at 04:28:54AM -0800, Neeraj Kumar Garg wrote:
> Provision discovery from a known peer should actually check for dev->flags & P2P_DEV_PROBE_REQ_ONLY. This is creating an issue of updating the listen frequency of peer with the PD request frame frequency. PD request frame will be sent by the peer on our local listen frequency. This patch fixes that error. Suggested check has already been implemented in the invitation req receive path.

Thanks! Applied.

Please read the CONTRIBUTIONS file in the root directory and use the
Signed-hostap tag for future contributions.

http://w1.fi/gitweb/gitweb.cgi?p=hostap.git;a=blob_plain;f=CONTRIBUTIONS

Patch

diff --git a/src/p2p/p2p_pd.c b/src/p2p/p2p_pd.c
index 6409454..a8f6912 100644
--- a/src/p2p/p2p_pd.c
+++ b/src/p2p/p2p_pd.c
@@ -112,7 +112,7 @@  void p2p_process_prov_disc_req(struct p2p_data *p2p, const u8 *sa,
 		MAC2STR(sa), msg.wps_config_methods, rx_freq);
 
 	dev = p2p_get_device(p2p, sa);
-	if (dev == NULL || !(dev->flags & P2P_DEV_PROBE_REQ_ONLY)) {
+	if (dev == NULL || (dev->flags & P2P_DEV_PROBE_REQ_ONLY)) {
 		wpa_msg(p2p->cfg->msg_ctx, MSG_DEBUG,
 			"P2P: Provision Discovery Request from "
 			"unknown peer " MACSTR, MAC2STR(sa));