Patchwork [08/19] dma: MX3_IPU fix depends

login
register
mail settings
Submitter Eric Benard
Date Dec. 13, 2011, 6:31 a.m.
Message ID <1323757911-25217-8-git-send-email-eric@eukrea.com>
Download mbox | patch
Permalink /patch/131010/
State New
Headers show

Comments

Eric Benard - Dec. 13, 2011, 6:31 a.m.
ARCH_MX3 was removed in e760b5260d39113794da17c64cbd6e6311155b66
thus preventing to select MX3_IPU, thus preventing IPU and display
to work on i.MX3x SOC.

Signed-off-by: Eric Bénard <eric@eukrea.com>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
---
 drivers/dma/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Sergei Shtylyov - Dec. 13, 2011, 10:53 a.m.
Hello.

On 13-12-2011 10:31, Eric Bénard wrote:

> ARCH_MX3 was removed in e760b5260d39113794da17c64cbd6e6311155b66

    Please also specify that commit's summary in parens.

> thus preventing to select MX3_IPU, thus preventing IPU and display
> to work on i.MX3x SOC.

> Signed-off-by: Eric Bénard<eric@eukrea.com>
> Cc: Sascha Hauer<kernel@pengutronix.de>
> Cc: Vinod Koul<vinod.koul@intel.com>
> Cc: Dan Williams<dan.j.williams@intel.com>

WBR, Sergei
Fabio Estevam - Dec. 13, 2011, 12:48 p.m.
On Tue, Dec 13, 2011 at 4:31 AM, Eric Bénard <eric@eukrea.com> wrote:
> ARCH_MX3 was removed in e760b5260d39113794da17c64cbd6e6311155b66
> thus preventing to select MX3_IPU, thus preventing IPU and display
> to work on i.MX3x SOC.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/dma/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index ab8f469..0b59fea 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -124,7 +124,7 @@ config MV_XOR
>
>  config MX3_IPU
>        bool "MX3x Image Processing Unit support"
> -       depends on ARCH_MX3
> +       depends on SOC_IMX31 || SOC_IMX35
>        select DMA_ENGINE
>        default y
>        help

On this same file there is another reference to ARCH_MX3 in the
"config IMX_SDMA"
dependency.

Care to send a patch fixing both locations?

Regards,

Fabio Estevam
Eric Benard - Dec. 13, 2011, 1:17 p.m.
Le 13/12/2011 11:53, Sergei Shtylyov a écrit :
> On 13-12-2011 10:31, Eric Bénard wrote:
>
>> ARCH_MX3 was removed in e760b5260d39113794da17c64cbd6e6311155b66
>
> Please also specify that commit's summary in parens.
>
good point, especially I pointed to the wrong commit.
v2 follows including change addressing Fabio's comments

Eric

Patch

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index ab8f469..0b59fea 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -124,7 +124,7 @@  config MV_XOR
 
 config MX3_IPU
 	bool "MX3x Image Processing Unit support"
-	depends on ARCH_MX3
+	depends on SOC_IMX31 || SOC_IMX35
 	select DMA_ENGINE
 	default y
 	help