Patchwork [7/7] arm/imx6q: register arm_clk to clkdev

login
register
mail settings
Submitter Richard Zhao
Date Dec. 12, 2011, 3:42 a.m.
Message ID <1323661352-10291-8-git-send-email-richard.zhao@linaro.org>
Download mbox | patch
Permalink /patch/130635/
State New
Headers show

Comments

Richard Zhao - Dec. 12, 2011, 3:42 a.m.
Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
---
 arch/arm/mach-imx/clock-imx6q.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Richard Zhao - Dec. 13, 2011, 1:33 a.m.
On Tue, Dec 13, 2011 at 09:34:34AM +0800, Shawn Guo wrote:
> On Mon, Dec 12, 2011 at 11:42:32AM +0800, Richard Zhao wrote:
> > Signed-off-by: Richard Zhao <richard.zhao@linaro.org>
> 
> It's always a good practice to add some commit message even for one
> line patch.  When you try to do that, you can usually find something
> to note in the message.  For this particular example, you may want to
> note why 'cpu_clk' needs to be in clk_lookup table.
right, I'll fix it in next version.

Thanks
Richard
> 
> Regards,
> Shawn
> 
> > ---
> >  arch/arm/mach-imx/clock-imx6q.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-imx/clock-imx6q.c b/arch/arm/mach-imx/clock-imx6q.c
> > index 039a7ab..2525380 100644
> > --- a/arch/arm/mach-imx/clock-imx6q.c
> > +++ b/arch/arm/mach-imx/clock-imx6q.c
> > @@ -1911,6 +1911,7 @@ static struct clk_lookup lookups[] = {
> >  	_REGISTER_CLOCK(NULL, "gpmi_io_clk", gpmi_io_clk),
> >  	_REGISTER_CLOCK(NULL, "usboh3_clk", usboh3_clk),
> >  	_REGISTER_CLOCK(NULL, "sata_clk", sata_clk),
> > +	_REGISTER_CLOCK(NULL, "cpu_clk", arm_clk),
> >  };
> >  
> >  int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode)
> > -- 
> > 1.7.5.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
Shawn Guo - Dec. 13, 2011, 1:34 a.m.
On Mon, Dec 12, 2011 at 11:42:32AM +0800, Richard Zhao wrote:
> Signed-off-by: Richard Zhao <richard.zhao@linaro.org>

It's always a good practice to add some commit message even for one
line patch.  When you try to do that, you can usually find something
to note in the message.  For this particular example, you may want to
note why 'cpu_clk' needs to be in clk_lookup table.

Regards,
Shawn

> ---
>  arch/arm/mach-imx/clock-imx6q.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/clock-imx6q.c b/arch/arm/mach-imx/clock-imx6q.c
> index 039a7ab..2525380 100644
> --- a/arch/arm/mach-imx/clock-imx6q.c
> +++ b/arch/arm/mach-imx/clock-imx6q.c
> @@ -1911,6 +1911,7 @@ static struct clk_lookup lookups[] = {
>  	_REGISTER_CLOCK(NULL, "gpmi_io_clk", gpmi_io_clk),
>  	_REGISTER_CLOCK(NULL, "usboh3_clk", usboh3_clk),
>  	_REGISTER_CLOCK(NULL, "sata_clk", sata_clk),
> +	_REGISTER_CLOCK(NULL, "cpu_clk", arm_clk),
>  };
>  
>  int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode)
> -- 
> 1.7.5.4

Patch

diff --git a/arch/arm/mach-imx/clock-imx6q.c b/arch/arm/mach-imx/clock-imx6q.c
index 039a7ab..2525380 100644
--- a/arch/arm/mach-imx/clock-imx6q.c
+++ b/arch/arm/mach-imx/clock-imx6q.c
@@ -1911,6 +1911,7 @@  static struct clk_lookup lookups[] = {
 	_REGISTER_CLOCK(NULL, "gpmi_io_clk", gpmi_io_clk),
 	_REGISTER_CLOCK(NULL, "usboh3_clk", usboh3_clk),
 	_REGISTER_CLOCK(NULL, "sata_clk", sata_clk),
+	_REGISTER_CLOCK(NULL, "cpu_clk", arm_clk),
 };
 
 int imx6q_set_lpm(enum mxc_cpu_pwr_mode mode)