From patchwork Fri Dec 9 16:04:25 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: libgo patch committed: Update to weekly.2011-11-09 From: Rainer Orth X-Patchwork-Id: 130412 Message-Id: To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Date: Fri, 09 Dec 2011 17:04:25 +0100 Ian Lance Taylor writes: > Rémy Oudompheng contributed a patch to upgrade the gccgo version of Go > library to the weekly.2011-11-09 release. This patch commits the change > to mainline. As usual with Go library updates, the patch is too large > to include here, and simply repeats changes made to the master library > in any case. I have as usual included the changes to files outside of > libgo/go. Bootstrapped and ran Go testsuite on > x86_64-unknown-linux-gnu. Committed to mainline. This patch led to many (all?) execution tests to fail on Solaris: Undefined first referenced symbol in file libgo_log.syslog.syslog_c /var/gcc/regression/trunk/11-gcc-gas/build/i386-pc-solaris2.11/./libgo/.libs/libgo.so ld: fatal: symbol referencing errors. No output written to /var/gcc/regression/trunk/11-gcc-gas/build/gcc/testsuite/go/array-1.x collect2: error: ld returned 1 exit status Fixed by the following patch. I've rebuilt libgo.so in mid-test and all subsequent tests are now passing. Rainer diff --git a/libgo/go/log/syslog/syslog_c.c b/libgo/go/log/syslog/syslog_c.c --- a/libgo/go/log/syslog/syslog_c.c +++ b/libgo/go/log/syslog/syslog_c.c @@ -10,7 +10,7 @@ can't represent a C varargs function in Go. */ void syslog_c(int, const char*) - asm ("libgo_syslog.syslog.syslog_c"); + asm ("libgo_log.syslog.syslog_c"); void syslog_c (int priority, const char *msg)