Patchwork libgo patch committed: Update to weekly.2011-11-09

login
register
mail settings
Submitter Rainer Orth
Date Dec. 9, 2011, 4:04 p.m.
Message ID <yddfwgtloja.fsf@manam.CeBiTec.Uni-Bielefeld.DE>
Download mbox | patch
Permalink /patch/130412/
State New
Headers show

Comments

Rainer Orth - Dec. 9, 2011, 4:04 p.m.
Ian Lance Taylor <iant@google.com> writes:

> Rémy Oudompheng contributed a patch to upgrade the gccgo version of Go
> library to the weekly.2011-11-09 release.  This patch commits the change
> to mainline.  As usual with Go library updates, the patch is too large
> to include here, and simply repeats changes made to the master library
> in any case.  I have as usual included the changes to files outside of
> libgo/go.  Bootstrapped and ran Go testsuite on
> x86_64-unknown-linux-gnu.  Committed to mainline.

This patch led to many (all?) execution tests to fail on Solaris:

Undefined                       first referenced
 symbol                             in file
libgo_log.syslog.syslog_c           /var/gcc/regression/trunk/11-gcc-gas/build/i386-pc-solaris2.11/./libgo/.libs/libgo.so
ld: fatal: symbol referencing errors. No output written to /var/gcc/regression/trunk/11-gcc-gas/build/gcc/testsuite/go/array-1.x
collect2: error: ld returned 1 exit status

Fixed by the following patch.  I've rebuilt libgo.so in mid-test and all
subsequent tests are now passing.

	Rainer
Ian Taylor - Dec. 9, 2011, 4:46 p.m.
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:

> This patch led to many (all?) execution tests to fail on Solaris:
>
> Undefined                       first referenced
>  symbol                             in file
> libgo_log.syslog.syslog_c           /var/gcc/regression/trunk/11-gcc-gas/build/i386-pc-solaris2.11/./libgo/.libs/libgo.so
> ld: fatal: symbol referencing errors. No output written to /var/gcc/regression/trunk/11-gcc-gas/build/gcc/testsuite/go/array-1.x
> collect2: error: ld returned 1 exit status
>
> Fixed by the following patch.  I've rebuilt libgo.so in mid-test and all
> subsequent tests are now passing.

Thanks for sorting this out.

Committed to mainline.

Ian

Patch

diff --git a/libgo/go/log/syslog/syslog_c.c b/libgo/go/log/syslog/syslog_c.c
--- a/libgo/go/log/syslog/syslog_c.c
+++ b/libgo/go/log/syslog/syslog_c.c
@@ -10,7 +10,7 @@ 
    can't represent a C varargs function in Go.  */
 
 void syslog_c(int, const char*)
-  asm ("libgo_syslog.syslog.syslog_c");
+  asm ("libgo_log.syslog.syslog_c");
 
 void
 syslog_c (int priority, const char *msg)