Patchwork [6/7] bonding: make tbl argument to bond_parse_parm() const

login
register
mail settings
Submitter holger@eitzenberger.org
Date Dec. 9, 2008, 8:07 p.m.
Message ID <20081209201451.115627905@eitzenberger.org>
Download mbox | patch
Permalink /patch/13041/
State Accepted
Delegated to: David Miller
Headers show

Comments

holger@eitzenberger.org - Dec. 9, 2008, 8:07 p.m.
bond_parse_parm() parses a parameter table for a particular value and
is therefore not modifying the table at all.  Therefore make the 2nd
argument const, thus allowing to make the tables const later.

Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>
David Miller - Dec. 10, 2008, 7:10 a.m.
From: holger@eitzenberger.org
Date: Tue, 09 Dec 2008 21:07:56 +0100

> bond_parse_parm() parses a parameter table for a particular value and
> is therefore not modifying the table at all.  Therefore make the 2nd
> argument const, thus allowing to make the tables const later.
> 
> Signed-off-by: Holger Eitzenberger <holger@eitzenberger.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: bonding-2.6-out/drivers/net/bonding/bond_main.c
===================================================================
--- bonding-2.6-out.orig/drivers/net/bonding/bond_main.c	2008-12-08 22:52:57.000000000 +0100
+++ bonding-2.6-out/drivers/net/bonding/bond_main.c	2008-12-08 22:53:12.000000000 +0100
@@ -4723,7 +4723,7 @@ 
  * some mode names are substrings of other names, and calls from sysfs
  * may have whitespace in the name (trailing newlines, for example).
  */
-int bond_parse_parm(const char *buf, struct bond_parm_tbl *tbl)
+int bond_parse_parm(const char *buf, const struct bond_parm_tbl *tbl)
 {
 	int mode = -1, i, rv;
 	char *p, modestr[BOND_MAX_MODENAME_LEN + 1] = { 0, };
Index: bonding-2.6-out/drivers/net/bonding/bonding.h
===================================================================
--- bonding-2.6-out.orig/drivers/net/bonding/bonding.h	2008-12-08 22:52:57.000000000 +0100
+++ bonding-2.6-out/drivers/net/bonding/bonding.h	2008-12-08 22:53:12.000000000 +0100
@@ -337,7 +337,7 @@ 
 void bond_loadbalance_arp_mon(struct work_struct *);
 void bond_activebackup_arp_mon(struct work_struct *);
 void bond_set_mode_ops(struct bonding *bond, int mode);
-int bond_parse_parm(const char *mode_arg, struct bond_parm_tbl *tbl);
+int bond_parse_parm(const char *mode_arg, const struct bond_parm_tbl *tbl);
 void bond_select_active_slave(struct bonding *bond);
 void bond_change_active_slave(struct bonding *bond, struct slave *new_active);
 void bond_register_arp(struct bonding *);