| Message ID | 20111209143611.9547BC2FFA@1024cores.msk.corp.google.com |
|---|---|
| State | New |
| Headers | show |
On 11-12-09 09:36 , Dmitriy Vyukov wrote: > This is for google-main branch. > Fix ThreadSanitizer pass required properties. > Turned out that PROP_gimple_lomp is not always present. > > Index: gcc/tree-tsan.c > =================================================================== > --- gcc/tree-tsan.c (revision 182099) > +++ gcc/tree-tsan.c (working copy) > @@ -1111,7 +1111,7 @@ > NULL, /* next */ > 0, /* static_pass_number */ > TV_NONE, /* tv_id */ > - PROP_trees | PROP_cfg, /* properties_required */ > + PROP_ssa | PROP_cfg, /* properties_required */ > 0, /* properties_provided */ > 0, /* properties_destroyed */ > 0, /* todo_flags_start */ > Index: gcc/ChangeLog.google-main > =================================================================== > --- gcc/ChangeLog.google-main (revision 182099) > +++ gcc/ChangeLog.google-main (working copy) > @@ -1,3 +1,8 @@ > +2011-12-09 Dmitriy Vyukov<dvyukov@google.com> > + > + Fix ThreadSanitizer pass required properties. > + * gcc/tree-tsan.c (pass_tsan): Replace PROP_trees with PROP_ssa. No need to mention what you are fixing in a ChangeLog entry. These entries are merely describing what changed, with no other content (yes, they are pretty useless nowadays). Also, the filename must be relative to the directory where the ChangeLog file lives. So, you don't need 'gcc/' in this case. OK with that change. Diego.
Index: gcc/tree-tsan.c =================================================================== --- gcc/tree-tsan.c (revision 182099) +++ gcc/tree-tsan.c (working copy) @@ -1111,7 +1111,7 @@ NULL, /* next */ 0, /* static_pass_number */ TV_NONE, /* tv_id */ - PROP_trees | PROP_cfg, /* properties_required */ + PROP_ssa | PROP_cfg, /* properties_required */ 0, /* properties_provided */ 0, /* properties_destroyed */ 0, /* todo_flags_start */ Index: gcc/ChangeLog.google-main =================================================================== --- gcc/ChangeLog.google-main (revision 182099) +++ gcc/ChangeLog.google-main (working copy) @@ -1,3 +1,8 @@ +2011-12-09 Dmitriy Vyukov <dvyukov@google.com> + + Fix ThreadSanitizer pass required properties. + * gcc/tree-tsan.c (pass_tsan): Replace PROP_trees with PROP_ssa. + 2011-12-05 Dmitriy Vyukov <dvyukov@google.com> Fix taking address of SSA_NAME in ThreadSanitizer pass.