Patchwork 3.2-rc1 rebase review

login
register
mail settings
Submitter Tetsuo Handa
Date Dec. 9, 2011, 3:21 a.m.
Message ID <201112090321.pB93LNQ8080056@www262.sakura.ne.jp>
Download mbox | patch
Permalink /patch/130277/
State New
Headers show

Comments

Tetsuo Handa - Dec. 9, 2011, 3:21 a.m.
Kees Cook wrote:
> >> Okay, I see what you mean now. It's skipping the register_security()
> >> part that hadn't sunk in. :)
> 
> Tetsuo, does this look okay to you? I incorportated some additional
> feedback about #ifdef clutter.

Looks OK, except one thing.
Kees Cook - Dec. 9, 2011, 4:10 a.m.
2011/12/8 Tetsuo Handa <from-ubuntu@i-love.sakura.ne.jp>:
> Kees Cook wrote:
> > +#if CONFIG_SECURITY_YAMA
>
> Please use "#ifdef CONFIG_SECURITY_YAMA".

Agh, I keep missing that. Thanks! I'll push the fix. :)

Patch

--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -3070,5 +3070,47 @@  static inline void free_secdata(void *secdata)
 { }
 #endif /* CONFIG_SECURITY */
 
+#if CONFIG_SECURITY_YAMA
+extern int yama_ptrace_access_check(struct task_struct *child,
+                                   unsigned int mode);
+extern int yama_path_link(struct dentry *old_dentry, struct path *new_dir,

Please use "#ifdef CONFIG_SECURITY_YAMA".

-- 
kernel-team mailing list
kernel-team@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/kernel-team