Patchwork arm/imx: fix cpufreq build error

login
register
mail settings
Submitter Shawn Guo
Date Dec. 9, 2011, 2:50 a.m.
Message ID <1323399055-31850-1-git-send-email-shawn.guo@linaro.org>
Download mbox | patch
Permalink /patch/130275/
State New
Headers show

Comments

Shawn Guo - Dec. 9, 2011, 2:50 a.m.
This patch adds missing linux/module.h to fix the build error seen
on imx cpuidle driver.

  CC      arch/arm/plat-mxc/cpufreq.o
arch/arm/plat-mxc/cpufreq.c:203: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:203: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:203: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
arch/arm/plat-mxc/cpufreq.c:203: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:204: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:204: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:204: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
arch/arm/plat-mxc/cpufreq.c:204: warning: function declaration isn't a prototype
arch/arm/plat-mxc/cpufreq.c:205: error: expected declaration specifiers or '...' before string constant
arch/arm/plat-mxc/cpufreq.c:205: warning: data definition has no type or storage class
arch/arm/plat-mxc/cpufreq.c:205: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
arch/arm/plat-mxc/cpufreq.c:205: warning: function declaration isn't a prototype
make[1]: *** [arch/arm/plat-mxc/cpufreq.o] Error 1
make: *** [arch/arm/plat-mxc] Error 2

Reported-by: Richard Zhao <richard.zhao@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
---
 arch/arm/plat-mxc/cpufreq.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Fabio Estevam - Dec. 9, 2011, 9:16 a.m.
On Fri, Dec 9, 2011 at 12:50 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> This patch adds missing linux/module.h to fix the build error seen
> on imx cpuidle driver.

It would be nice to add which was the commit that introduced this build error.

Regards,

Fabio Estevam
Wolfram Sang - Dec. 9, 2011, 9:26 a.m.
On Fri, Dec 09, 2011 at 10:50:55AM +0800, Shawn Guo wrote:
> This patch adds missing linux/module.h to fix the build error seen
> on imx cpuidle driver.
> 
>   CC      arch/arm/plat-mxc/cpufreq.o
> arch/arm/plat-mxc/cpufreq.c:203: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:203: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:203: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
> arch/arm/plat-mxc/cpufreq.c:203: warning: function declaration isn't a prototype
> arch/arm/plat-mxc/cpufreq.c:204: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:204: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:204: warning: type defaults to 'int' in declaration of 'MODULE_DESCRIPTION'
> arch/arm/plat-mxc/cpufreq.c:204: warning: function declaration isn't a prototype
> arch/arm/plat-mxc/cpufreq.c:205: error: expected declaration specifiers or '...' before string constant
> arch/arm/plat-mxc/cpufreq.c:205: warning: data definition has no type or storage class
> arch/arm/plat-mxc/cpufreq.c:205: warning: type defaults to 'int' in declaration of 'MODULE_LICENSE'
> arch/arm/plat-mxc/cpufreq.c:205: warning: function declaration isn't a prototype
> make[1]: *** [arch/arm/plat-mxc/cpufreq.o] Error 1
> make: *** [arch/arm/plat-mxc] Error 2
> 
> Reported-by: Richard Zhao <richard.zhao@freescale.com>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

Patch

diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
index 74aac96..e3073be 100644
--- a/arch/arm/plat-mxc/cpufreq.c
+++ b/arch/arm/plat-mxc/cpufreq.c
@@ -20,6 +20,7 @@ 
 #include <linux/cpufreq.h>
 #include <linux/clk.h>
 #include <linux/err.h>
+#include <linux/module.h>
 #include <linux/slab.h>
 #include <mach/hardware.h>
 #include <mach/clock.h>