From patchwork Fri Dec 9 01:39:55 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Breeds X-Patchwork-Id: 130274 X-Patchwork-Delegate: galak@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [IPv6:::1]) by ozlabs.org (Postfix) with ESMTP id 04676100824 for ; Fri, 9 Dec 2011 12:40:10 +1100 (EST) Received: from thor.bakeyournoodle.com (ibmaus65.lnk.telstra.net [165.228.126.9]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPSA id 3503A1007D6; Fri, 9 Dec 2011 12:39:59 +1100 (EST) Date: Fri, 9 Dec 2011 12:39:55 +1100 From: Tony Breeds To: Michael Neuling Subject: [PATCH] powerpc: fix compile error with 85xx/p1010rdb.c Message-ID: <20111209013955.GD20353@thor.bakeyournoodle.com> Mail-Followup-To: Michael Neuling , Kyle Moffett , Benjamin Herrenschmidt , Paul Mackerras , linux-next@vger.kernel.org, linuxppc-dev , Michael Ellerman , sfr@canb.auug.org.au References: <7679.1323324654@neuling.org> MIME-Version: 1.0 In-Reply-To: <7679.1323324654@neuling.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: sfr@canb.auug.org.au, Michael Ellerman , linux-next@vger.kernel.org, Paul Mackerras , Kyle Moffett , linuxppc-dev X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org Current linux-next compiled with mpc85xx_defconfig causes this: arch/powerpc/platforms/85xx/p1010rdb.c:41:14: error: 'np' undeclared (first use in this function) arch/powerpc/platforms/85xx/p1023_rds.c:102:14: error: 'np' undeclared (first use in this function) Introduced in: commit 996983b75cebb1bc1c2c545f20336f24ebfa17af Author: Kyle Moffett Date: Fri Dec 2 06:28:02 2011 +0000 powerpc/mpic: Search for open-pic device-tree node if NULL Signed-off-by: Tony Breeds --- Mikey already posted a fix for p1023_rds.c. I think this is the last one. arch/powerpc/platforms/85xx/p1010rdb.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/85xx/p1010rdb.c b/arch/powerpc/platforms/85x index 894f1e8..538bc3f 100644 --- a/arch/powerpc/platforms/85xx/p1010rdb.c +++ b/arch/powerpc/platforms/85xx/p1010rdb.c @@ -38,10 +38,8 @@ void __init p1010_rdb_pic_init(void) 0, 256, " OpenPIC "); BUG_ON(mpic == NULL); - of_node_put(np); mpic_init(mpic); - } Yours Tony