| Message ID | 1323367477-21685-7-git-send-email-kamal@canonical.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu 08-12-11 10:04:36, Kamal Mostafa wrote: > From: Valerie Aurora <val@vaaconsulting.com> Looks good. You can add: Acked-by: Jan Kara <jack@suse.cz> Honza > BugLink: https://bugs.launchpad.net/bugs/897421 > Signed-off-by: Valerie Aurora <val@vaaconsulting.com> > Cc: Kamal Mostafa <kamal@canonical.com> > Tested-by: Peter M. Petrakis <peter.petrakis@canonical.com> > [kamal@canonical.com: patch restructure] > Signed-off-by: Kamal Mostafa <kamal@canonical.com> > --- > fs/super.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/fs/super.c b/fs/super.c > index 5629d06..a56696b 100644 > --- a/fs/super.c > +++ b/fs/super.c > @@ -1140,6 +1140,24 @@ out: > * Syncs the super to make sure the filesystem is consistent and calls the fs's > * freeze_fs. Subsequent calls to this without first thawing the fs will return > * -EBUSY. > + * > + * During this function, sb->s_frozen goes through these values: > + * > + * SB_UNFROZEN: File system is normal, all writes progress as usual. > + * > + * SB_FREEZE_WRITE: The file system is in the process of being frozen > + * and any remaining out-standing writes are being synced. Writes > + * that complete in-process writes should be permitted but new ones > + * should be blocked. > + * > + * SB_FREEZE_TRANS: The file system is frozen. The ->freeze_fs and > + * ->unfreeze_fs ops are the only operations permitted to write to the > + * file system in this state. > + * > + * sb->s_frozen is protected by sb->s_umount. Additionally, > + * SB_FREEZE_WRITE is only temporarily set during freeze/thaw while > + * holding sb->s_umount for writing, so any other callers holding > + * sb->s_umount will never see this state. > */ > int freeze_super(struct super_block *sb) > { > -- > 1.7.5.4 >
diff --git a/fs/super.c b/fs/super.c index 5629d06..a56696b 100644 --- a/fs/super.c +++ b/fs/super.c @@ -1140,6 +1140,24 @@ out: * Syncs the super to make sure the filesystem is consistent and calls the fs's * freeze_fs. Subsequent calls to this without first thawing the fs will return * -EBUSY. + * + * During this function, sb->s_frozen goes through these values: + * + * SB_UNFROZEN: File system is normal, all writes progress as usual. + * + * SB_FREEZE_WRITE: The file system is in the process of being frozen + * and any remaining out-standing writes are being synced. Writes + * that complete in-process writes should be permitted but new ones + * should be blocked. + * + * SB_FREEZE_TRANS: The file system is frozen. The ->freeze_fs and + * ->unfreeze_fs ops are the only operations permitted to write to the + * file system in this state. + * + * sb->s_frozen is protected by sb->s_umount. Additionally, + * SB_FREEZE_WRITE is only temporarily set during freeze/thaw while + * holding sb->s_umount for writing, so any other callers holding + * sb->s_umount will never see this state. */ int freeze_super(struct super_block *sb) {