| Message ID | 1222272700-28232-3-git-send-email-remi.denis-courmont@nokia.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Remi Denis-Courmont <remi.denis-courmont@nokia.com> Date: Wed, 24 Sep 2008 19:11:40 +0300 > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> Applied. I took a look and noticed that if_phonet.h needs some top-level ifdef multiple inclusion protection. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tuesday 30 September 2008 12:59:57 ext David Miller, you wrote: > From: Remi Denis-Courmont <remi.denis-courmont@nokia.com> > Date: Wed, 24 Sep 2008 19:11:40 +0300 > > > Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> > > Applied. > > I took a look and noticed that if_phonet.h needs some top-level > ifdef multiple inclusion protection. Oops. Patch follows. While we're on if_phonet.h, I also wonder what the "right" place for phonet_header_ops is... Currently in phonet.ko, any network device driver link-depends on the socket stack :-( for two tiny little header_ops callbacks. Is that OK? or should it go to core like the Ethernet ops, or be inline'd? Regards,
From: "Rémi Denis-Courmont" <remi.denis-courmont@nokia.com> Date: Wed, 1 Oct 2008 10:54:52 +0300 > While we're on if_phonet.h, I also wonder what the "right" place for > phonet_header_ops is... Currently in phonet.ko, any network device driver > link-depends on the socket stack :-( for two tiny little header_ops > callbacks. Is that OK? or should it go to core like the Ethernet ops, or be > inline'd? The drivers are kind of useless without the socket layer so it doesn't seem so awful to have this dependency. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/Kbuild b/include/linux/Kbuild index b68ec09..f431e40 100644 --- a/include/linux/Kbuild +++ b/include/linux/Kbuild @@ -126,6 +126,7 @@ header-y += pci_regs.h header-y += pfkeyv2.h header-y += pg.h header-y += phantom.h +header-y += phonet.h header-y += pkt_cls.h header-y += pkt_sched.h header-y += posix_types.h @@ -232,6 +233,7 @@ unifdef-y += if_fddi.h unifdef-y += if_frad.h unifdef-y += if_ltalk.h unifdef-y += if_link.h +unifdef-y += if_phonet.h unifdef-y += if_pppol2tp.h unifdef-y += if_pppox.h unifdef-y += if_tr.h
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/linux/Kbuild | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)