From patchwork Tue Dec 6 12:58:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 129683 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 77EDB1007D5 for ; Wed, 7 Dec 2011 00:36:40 +1100 (EST) Received: from localhost ([::1]:53444 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXucQ-0002mA-Ql for incoming@patchwork.ozlabs.org; Tue, 06 Dec 2011 07:59:34 -0500 Received: from eggs.gnu.org ([140.186.70.92]:58993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXubb-0000wM-MW for qemu-devel@nongnu.org; Tue, 06 Dec 2011 07:58:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXubO-0002aV-N3 for qemu-devel@nongnu.org; Tue, 06 Dec 2011 07:58:43 -0500 Received: from david.siemens.de ([192.35.17.14]:18106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXubO-0002Z3-9d for qemu-devel@nongnu.org; Tue, 06 Dec 2011 07:58:30 -0500 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id pB6CwSkQ007850; Tue, 6 Dec 2011 13:58:28 +0100 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id pB6CwHqB011829; Tue, 6 Dec 2011 13:58:27 +0100 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Date: Tue, 6 Dec 2011 13:58:08 +0100 Message-Id: <9cf717ed048091326ec84dfa387566a9b720de6d.1323176291.git.jan.kiszka@siemens.com> X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 192.35.17.14 Cc: Blue Swirl , Anthony Liguori , qemu-devel , kvm@vger.kernel.org, "Michael S. Tsirkin" Subject: [Qemu-devel] [PATCH v3 08/16] ioapic: Reject non-dword accesses to IOWIN register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Aligns the model with the spec. Signed-off-by: Jan Kiszka --- hw/ioapic.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/ioapic.c b/hw/ioapic.c index 56b1612..eb75766 100644 --- a/hw/ioapic.c +++ b/hw/ioapic.c @@ -208,6 +208,9 @@ ioapic_mem_read(void *opaque, target_phys_addr_t addr, unsigned int size) val = s->ioregsel; break; case IOAPIC_IOWIN: + if (size != 4) { + break; + } switch (s->ioregsel) { case IOAPIC_REG_ID: val = s->id << IOAPIC_ID_SHIFT; @@ -247,6 +250,9 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, uint64_t val, s->ioregsel = val; break; case IOAPIC_IOWIN: + if (size != 4) { + break; + } DPRINTF("write: %08x = %08x\n", s->ioregsel, val); switch (s->ioregsel) { case IOAPIC_REG_ID: