Patchwork [(mtd-www),01/13] nand-data: update TC58DVM72A1TG00 BBM info

login
register
mail settings
Submitter Angus CLARK
Date Dec. 6, 2011, 12:07 p.m.
Message ID <1323173269-19931-1-git-send-email-angus.clark@st.com>
Download mbox | patch
Permalink /patch/129643/
State Accepted
Commit 5c53cdcdd2e2d66912c17a9d60e12a3e79d7ffbb
Headers show

Comments

Angus CLARK - Dec. 6, 2011, 12:07 p.m.
Update Toshiba TC58DVM72A1TG00 bad block marker information to "1st page (6th
byte in OOB = non FFh)", as described in datasheet, and confirmed with Toshiba
engineers.

Signed-off-by: Angus Clark <angus.clark@st.com>
---
 nand-data/nanddata.csv |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Artem Bityutskiy - Dec. 6, 2011, 9:02 p.m.
On Tue, 2011-12-06 at 12:07 +0000, Angus CLARK wrote:
> Update Toshiba TC58DVM72A1TG00 bad block marker information to "1st page (6th
> byte in OOB = non FFh)", as described in datasheet, and confirmed with Toshiba
> engineers.
> 
> Signed-off-by: Angus Clark <angus.clark@st.com>

Thanks, I'll let Brian comment on this first.

Artem.
Brian Norris - Dec. 7, 2011, 6:14 p.m.
On Tue, Dec 6, 2011 at 1:02 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2011-12-06 at 12:07 +0000, Angus CLARK wrote:
>> Update Toshiba TC58DVM72A1TG00 bad block marker information to "1st page (6th
>> byte in OOB = non FFh)", as described in datasheet, and confirmed with Toshiba
>> engineers.
>>
>> Signed-off-by: Angus Clark <angus.clark@st.com>
>
> Thanks, I'll let Brian comment on this first.

I'll get to all of these eventually!

Regarding this patch:

I believe I misread my data sheet on this one. Thanks for reviewing.

Not sure if an Ack or Signed-off-by is in order...

Acked-by: Brian Norris <computersforpeace@gmail.com>
Artem Bityutskiy - Dec. 8, 2011, 10:16 p.m.
On Wed, 2011-12-07 at 10:14 -0800, Brian Norris wrote:
> Acked-by: Brian Norris <computersforpeace@gmail.com>

Pushed patches: 01, 03, 04, 07, 08, 09

Thanks Angus!
Artem Bityutskiy - Dec. 8, 2011, 10:18 p.m.
On Tue, 2011-12-06 at 12:07 +0000, Angus CLARK wrote:
> Update Toshiba TC58DVM72A1TG00 bad block marker information to "1st page (6th
> byte in OOB = non FFh)", as described in datasheet, and confirmed with Toshiba
> engineers.
> 
> Signed-off-by: Angus Clark <angus.clark@st.com>

Could you please use --no-chain-reply-to when using git-send-email, or
better add this option to you ~/.gitconfig - I think it is generally
known that chained replies are PITA to use, especially with long patch
series.

Thanks!

Patch

diff --git a/nand-data/nanddata.csv b/nand-data/nanddata.csv
index 09876ab..92bee24 100644
--- a/nand-data/nanddata.csv
+++ b/nand-data/nanddata.csv
@@ -1,7 +1,7 @@ 
 "Manufacturer","Part #","Man. ID","ID Code","Full ID","MB","Page","OOB","Block","Bus","ONFI Ver.","Bad Block Location","Scan Page 2","Scan last page","Scan (last-2)th page","Scan byte 1","Scan byte 6","ECC Req.","Bits per cell","ID Length","Detection Method","Full Support","ONFI-Capable","All but Size","Correct Size","Correct Page","Correct OOB","Correct Block","Correct Busw","Correct BBM","Notes"
 "Toshiba","TC58128AFT","0x98","0x73","0x9873",16,512,16,"16 KB","x8","N/A","All OOB bytes",TRUE,TRUE,FALSE,TRUE,TRUE,"?","1?",2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,"For BBM, OOB is written non-FFh (only check 1st page, 1st byte?)"
 "Samsung","K9F1G08U0B","0xEC","0xF1","0xECF1009540",128,2048,64,"128 KB","x8","N/A","1st or 2nd page (1st byte in OOB = non FFh)",TRUE,FALSE,FALSE,TRUE,FALSE,"1-bit/512-byte",1,5,"Extended ID decode",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,
-"Toshiba","TC58DVM72A1TG00","0x98","0x73","0x9873",16,512,16,"16 KB","x8","N/A","All OOB bytes",TRUE,TRUE,FALSE,TRUE,TRUE,"?","1?",2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,"For BBM, OOB is written non-FFh (only check 1st page, 1st byte?)"
+"Toshiba","TC58DVM72A1TG00","0x98","0x73","0x9873",16,512,16,"16 KB","x8","N/A","1st page (6th byte in OOB = non FFh)",FALSE,FALSE,FALSE,FALSE,TRUE,"?","1?",2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,
 "Samsung","K9F5608D0C","0xEC","0x75","0xEC75",32,512,16,"16 KB","x8","N/A","1st or 2nd page (6th byte in OOB = non FFh)",TRUE,FALSE,FALSE,FALSE,TRUE,"? (1-bit correct, 2-bit detect)",1,2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,
 "Samsung","K9F5608Q0C","0xEC","0x35","0xEC35",32,512,16,"16 KB","x8","N/A","1st or 2nd page (6th byte in OOB = non FFh)",TRUE,FALSE,FALSE,FALSE,TRUE,"? (1-bit correct, 2-bit detect)",1,2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,
 "Samsung","K9F5608U0C","0xEC","0x75","0xEC75",32,512,16,"16 KB","x8","N/A","1st or 2nd page (6th byte in OOB = non FFh)",TRUE,FALSE,FALSE,FALSE,TRUE,"? (1-bit correct, 2-bit detect)",1,2,"ID Table",TRUE,FALSE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,TRUE,