Patchwork [03/19] console: Fix qemu_default_pixelformat() for 24 bpp

login
register
mail settings
Submitter Stefan Hajnoczi
Date Dec. 6, 2011, 11 a.m.
Message ID <1323169274-31657-4-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/129622/
State New
Headers show

Comments

Stefan Hajnoczi - Dec. 6, 2011, 11 a.m.
From: Markus Armbruster <armbru@redhat.com>

Falls through to 32 bpp.  Harmless, because the only difference is the
alpha component, and we're not using that.  Spotted by Coverity.

Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 console.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/console.c b/console.c
index ce0429d..223f8fd 100644
--- a/console.c
+++ b/console.c
@@ -1688,6 +1688,7 @@  PixelFormat qemu_default_pixelformat(int bpp)
             pf.rbits = 8;
             pf.gbits = 8;
             pf.bbits = 8;
+            break;
         case 32:
             pf.rmask = 0x00FF0000;
             pf.gmask = 0x0000FF00;