Patchwork [02/19] console: Fix console_putchar() for CSI J

login
register
mail settings
Submitter Stefan Hajnoczi
Date Dec. 6, 2011, 11 a.m.
Message ID <1323169274-31657-3-git-send-email-stefanha@linux.vnet.ibm.com>
Download mbox | patch
Permalink /patch/129618/
State New
Headers show

Comments

Stefan Hajnoczi - Dec. 6, 2011, 11 a.m.
From: Markus Armbruster <armbru@redhat.com>

It falls through to the code for CSI K.  "Erase Down" also does "Erase
End of Line", "Erase Up" also does "Erase Start of Line", and "Erase
Screen" also does "Erase Line".  Happens not to be visible.  Fix it
anyway.  Spotted by Coverity.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 console.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/console.c b/console.c
index 374fcba..ce0429d 100644
--- a/console.c
+++ b/console.c
@@ -1011,6 +1011,7 @@  static void console_putchar(TextConsole *s, int ch)
                     }
                     break;
                 }
+                break;
             case 'K':
                 switch (s->esc_params[0]) {
                 case 0: