Patchwork [1/1] lib: fwts_acpi_find_rsdp_bios should only scan for RSDP on Intel/AMD

login
register
mail settings
Submitter Colin King
Date Dec. 5, 2011, 6:37 p.m.
Message ID <1323110246-15547-2-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/129395/
State Accepted
Headers show

Comments

Colin King - Dec. 5, 2011, 6:37 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 src/lib/src/fwts_acpi_tables.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
Alex Hung - Jan. 3, 2012, 10:02 a.m.
Hi Colin,

Ack from me

Cheers,
Alex Hung

On 12/06/2011 02:37 AM, Colin King wrote:
> From: Colin Ian King<colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King<colin.king@canonical.com>
> ---
>   src/lib/src/fwts_acpi_tables.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
> index 96b4044..3ea919b 100644
> --- a/src/lib/src/fwts_acpi_tables.c
> +++ b/src/lib/src/fwts_acpi_tables.c
> @@ -56,6 +56,7 @@ static void *fwts_acpi_find_rsdp_efi(void)
>    */
>   static void *fwts_acpi_find_rsdp_bios(void)
>   {
> +#ifdef FWTS_ARCH_INTEL
>   	uint8_t *bios;
>   	uint8_t *ptr;
>   	fwts_acpi_table_rsdp *rsdp;
> @@ -79,6 +80,9 @@ static void *fwts_acpi_find_rsdp_bios(void)
>   	(void)fwts_munmap(bios, BIOS_LENGTH);
>
>   	return addr;
> +#else
> +	return NULL;
> +#endif
>   }
>
>   /*
Keng-Yu Lin - Jan. 9, 2012, 9 a.m.
Ack and applied.

On Tue, Jan 3, 2012 at 11:02 AM, Alex Hung <alex.hung@canonical.com> wrote:
> Hi Colin,
>
> Ack from me
>
> Cheers,
> Alex Hung
>
> On 12/06/2011 02:37 AM, Colin King wrote:
>>
>> From: Colin Ian King<colin.king@canonical.com>
>>
>> Signed-off-by: Colin Ian King<colin.king@canonical.com>
>> ---
>>  src/lib/src/fwts_acpi_tables.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/src/lib/src/fwts_acpi_tables.c
>> b/src/lib/src/fwts_acpi_tables.c
>> index 96b4044..3ea919b 100644
>> --- a/src/lib/src/fwts_acpi_tables.c
>> +++ b/src/lib/src/fwts_acpi_tables.c
>> @@ -56,6 +56,7 @@ static void *fwts_acpi_find_rsdp_efi(void)
>>   */
>>  static void *fwts_acpi_find_rsdp_bios(void)
>>  {
>> +#ifdef FWTS_ARCH_INTEL
>>        uint8_t *bios;
>>        uint8_t *ptr;
>>        fwts_acpi_table_rsdp *rsdp;
>> @@ -79,6 +80,9 @@ static void *fwts_acpi_find_rsdp_bios(void)
>>        (void)fwts_munmap(bios, BIOS_LENGTH);
>>
>>        return addr;
>> +#else
>> +       return NULL;
>> +#endif
>>  }
>>
>>  /*
>
>
>
> --
> fwts-devel mailing list
> fwts-devel@lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/fwts-devel

Patch

diff --git a/src/lib/src/fwts_acpi_tables.c b/src/lib/src/fwts_acpi_tables.c
index 96b4044..3ea919b 100644
--- a/src/lib/src/fwts_acpi_tables.c
+++ b/src/lib/src/fwts_acpi_tables.c
@@ -56,6 +56,7 @@  static void *fwts_acpi_find_rsdp_efi(void)
  */
 static void *fwts_acpi_find_rsdp_bios(void)
 {
+#ifdef FWTS_ARCH_INTEL
 	uint8_t *bios;
 	uint8_t *ptr;
 	fwts_acpi_table_rsdp *rsdp;
@@ -79,6 +80,9 @@  static void *fwts_acpi_find_rsdp_bios(void)
 	(void)fwts_munmap(bios, BIOS_LENGTH);
 
 	return addr;
+#else
+	return NULL;
+#endif
 }
 
 /*