From patchwork Mon Dec 5 17:24:13 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [8/9] libsi: don't leak a struct srvinfo upon failed strdup Date: Mon, 05 Dec 2011 07:24:13 -0000 From: Chuck Lever X-Patchwork-Id: 129381 Message-Id: <20111205172413.7753.52192.stgit@degas.1015granger.net> To: fedfs-utils-devel@oss.oracle.com From: Jim Meyering * src/libsi/getsrvinfo.c (getsrvinfo): Free "new". Spotted by coverity. Introduced in commit 0520ee72: "Initial commit," (March 29, 2011). Signed-off-by: Jim Meyering --- src/libsi/getsrvinfo.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/libsi/getsrvinfo.c b/src/libsi/getsrvinfo.c index 7a465c7..931847e 100644 --- a/src/libsi/getsrvinfo.c +++ b/src/libsi/getsrvinfo.c @@ -289,6 +289,7 @@ getsrvinfo(const char *srvname, const char *domainname, struct srvinfo **si) new->si_target = strdup(exp_dn); if (new->si_target == NULL) { + free(new); status = ESI_MEMORY; goto out; }