Patchwork [8/9] libsi: don't leak a struct srvinfo upon failed strdup

login
register
mail settings
Submitter Chuck Lever
Date Dec. 5, 2011, 5:24 p.m.
Message ID <20111205172413.7753.52192.stgit@degas.1015granger.net>
Download mbox | patch
Permalink /patch/129381/
State Accepted
Headers show

Comments

Chuck Lever - Dec. 5, 2011, 5:24 p.m.
From: Jim Meyering <meyering@redhat.com>

* src/libsi/getsrvinfo.c (getsrvinfo): Free "new".
Spotted by coverity.

Introduced in commit 0520ee72: "Initial commit," (March 29, 2011).

Signed-off-by: Jim Meyering <meyering@redhat.com>
---

 src/libsi/getsrvinfo.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/src/libsi/getsrvinfo.c b/src/libsi/getsrvinfo.c
index 7a465c7..931847e 100644
--- a/src/libsi/getsrvinfo.c
+++ b/src/libsi/getsrvinfo.c
@@ -289,6 +289,7 @@  getsrvinfo(const char *srvname, const char *domainname, struct srvinfo **si)
 
 		new->si_target = strdup(exp_dn);
 		if (new->si_target == NULL) {
+			free(new);
 			status = ESI_MEMORY;
 			goto out;
 		}