Patchwork [7/9] libnsdb: don't leak a read buffer upon certfile open failure

login
register
mail settings
Submitter Chuck Lever
Date Dec. 5, 2011, 5:24 p.m.
Message ID <20111205172404.7753.1340.stgit@degas.1015granger.net>
Download mbox | patch
Permalink /patch/129380/
State Accepted
Headers show

Comments

Chuck Lever - Dec. 5, 2011, 5:24 p.m.
From: Jim Meyering <meyering@redhat.com>

* src/libnsdb/nsdb.c (nsdb_read_certfile): Free "buf" also
on the failed-open path.  Spotted by coverity.

Introduced by commit 0520ee72: "Initial commit," (March 29, 2011).

Signed-off-by: Jim Meyering <meyering@redhat.com>
---

 src/libnsdb/nsdb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/src/libnsdb/nsdb.c b/src/libnsdb/nsdb.c
index c81f228..02c0588 100644
--- a/src/libnsdb/nsdb.c
+++ b/src/libnsdb/nsdb.c
@@ -524,6 +524,7 @@  nsdb_read_certfile(const char *pathname, char **certdata,
 	if (fd == -1) {
 		xlog(D_GENERAL, "%s: Failed to open %s: %m",
 			__func__, pathname);
+		free(buf);
 		goto out;
 	}