Message ID | CAGkQGiLMc-uftxMbZC_zCDiXQcr3+CxgSQGbZMxM+KNbFJHCLg@mail.gmail.com |
---|---|
State | New |
Headers | show |
Dear Paul, Paul Richard Thomas wrote: > Are you checking to see if the patches really are reviewed :-) t I am - but involuntarily. I am sure that I build and regtested - but seemingly a different tree :-( > The latter change gets rejected with my class array patch in place > because I have: I am really looking forward to have that patch in the trunk - it makes patch writing and testing easier if one does not have two separate trees, one clean with minor patches and one with your patch and occasionally some on-top patches. > This is OK: > > c->attr.pointer = attr->pointer || (attr->allocatable ? 0 : attr->dummy) > || attr->select_type_temporary; I have now used || (attr->dummy && !attr->allocatable) instead of || (attr->allocatable ? 0 : attr->dummy) which I found more readable. I did also did a rebuild, regtested it and committed the patch as Rev. 181975. Thanks for the careful review! Tobias
Index: gcc/fortran/class.c =================================================================== --- gcc/fortran/class.c (Revision 181967) +++ gcc/fortran/class.c (Arbeitskopie) @@ -188,7 +188,8 @@ gfc_build_class_symbol (gfc_typespec *ts, symbol_a /* Class container has already been built. */ return SUCCESS; - attr->class_ok = attr->dummy || attr->pointer || attr->allocatable; + attr->class_ok = attr->dummy || attr->pointer || attr->allocatable + || attr.select_type_temporary; /* Ahem, ahem! */ if (!attr->class_ok)