| Submitter | Anthony Liguori |
|---|---|
| Date | Dec. 2, 2011, 8:20 p.m. |
| Message ID | <1322857256-14951-10-git-send-email-aliguori@us.ibm.com> |
| Download | mbox | patch |
| Permalink | /patch/128970/ |
| State | New |
| Headers | show |
Comments
Am 02.12.2011 21:20, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > --- > scripts/qapi-commands.py | 1 + > scripts/qapi-types.py | 1 + > 2 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py > index f7def16..54d1f5d 100644 > --- a/scripts/qapi-commands.py > +++ b/scripts/qapi-commands.py > @@ -405,6 +405,7 @@ except os.error, e: > > exprs = parse_schema(sys.stdin) > commands = filter(lambda expr: expr.has_key('command'), exprs) > +commands = filter(lambda expr: not expr.has_key('gen'), commands) Might be confusing if someone uses something like gen = True. Shouldn't we better check the value instead of just existence? Kevin
On 12/08/2011 10:04 AM, Kevin Wolf wrote: > Am 02.12.2011 21:20, schrieb Anthony Liguori: >> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com> >> --- >> scripts/qapi-commands.py | 1 + >> scripts/qapi-types.py | 1 + >> 2 files changed, 2 insertions(+), 0 deletions(-) >> >> diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py >> index f7def16..54d1f5d 100644 >> --- a/scripts/qapi-commands.py >> +++ b/scripts/qapi-commands.py >> @@ -405,6 +405,7 @@ except os.error, e: >> >> exprs = parse_schema(sys.stdin) >> commands = filter(lambda expr: expr.has_key('command'), exprs) >> +commands = filter(lambda expr: not expr.has_key('gen'), commands) > > Might be confusing if someone uses something like gen = True. Shouldn't > we better check the value instead of just existence? Yes, it was a lazy short cut. I'll fix appropriately. Regards, Anthony Liguori > > Kevin >
Patch
diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index f7def16..54d1f5d 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-commands.py @@ -405,6 +405,7 @@ except os.error, e: exprs = parse_schema(sys.stdin) commands = filter(lambda expr: expr.has_key('command'), exprs) +commands = filter(lambda expr: not expr.has_key('gen'), commands) if dispatch_type == "sync": fdecl = open(h_file, 'w') diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index f64d84c..267cb49 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -238,6 +238,7 @@ fdecl.write(mcgen(''' guard=guardname(h_file))) exprs = parse_schema(sys.stdin) +exprs = filter(lambda expr: not expr.has_key('gen'), exprs) for expr in exprs: ret = "\n"
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> --- scripts/qapi-commands.py | 1 + scripts/qapi-types.py | 1 + 2 files changed, 2 insertions(+), 0 deletions(-)