From patchwork Fri Dec 2 12:13:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Meyering X-Patchwork-Id: 128825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "rcsinet15.oracle.com", Issuer "VeriSign Class 3 International Server CA - G3" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id 9073CB6F67 for ; Fri, 2 Dec 2011 23:14:15 +1100 (EST) Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id pB2CDwFV001266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 2 Dec 2011 12:13:58 GMT Received: from oss.oracle.com (oss.oracle.com [141.146.12.120]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id pB2CDuV9026775 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 2 Dec 2011 12:13:57 GMT Received: from localhost ([127.0.0.1] helo=oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1RWRzz-0001ef-RR; Fri, 02 Dec 2011 04:13:51 -0800 Received: from rcsinet13.oracle.com ([148.87.113.125]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1RWRzx-0001eW-6P for fedfs-utils-devel@oss.oracle.com; Fri, 02 Dec 2011 04:13:49 -0800 Received: from mx.meyering.net (mx.meyering.net [88.168.87.75]) by rcsinet13.oracle.com (Sentrion-MTA-4.2.0/Sentrion-MTA-4.2.0) with ESMTP id pB2CDkur019168 for ; Fri, 2 Dec 2011 12:13:48 GMT Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 2FBF160193; Fri, 2 Dec 2011 13:13:45 +0100 (CET) From: Jim Meyering To: Chuck Lever In-Reply-To: (Chuck Lever's message of "Thu, 1 Dec 2011 12:19:36 -0500") References: <1322742439-2171-1-git-send-email-jim@meyering.net> <1322742439-2171-4-git-send-email-jim@meyering.net> Date: Fri, 02 Dec 2011 13:13:45 +0100 Message-ID: <87sjl35fye.fsf@rho.meyering.net> Lines: 58 MIME-Version: 1.0 Cc: fedfs-utils Developers Subject: Re: [fedfs-utils] [PATCH v2 3/8] build: avoid automake warnings about AM_PROG_AR requirement X-BeenThere: fedfs-utils-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list Reply-To: fedfs-utils Developers List-Id: fedfs-utils Developers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: fedfs-utils-devel-bounces@oss.oracle.com Errors-To: fedfs-utils-devel-bounces@oss.oracle.com X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-CT-RefId: str=0001.0A090206.4ED8C108.008A:SCFSTAT3865452, ss=1, re=-4.000, fgs=0 Chuck Lever wrote: > On Dec 1, 2011, at 7:27 AM, Jim Meyering wrote: >> From: Jim Meyering >> * configure.ac: Use AM_PROG_AR (must precede LT_INIT). >> Without this, when using what will soon be automake-1.11.2, we'd >> get a warning like this for each .a file: ... > After applying this on my Fedora 15 build system, I get: > > [cel@degas fedfs-utils]$ sh ./autogen.sh > cleaning up................... done > configure.ac:35: warning: macro `AM_PROG_AR' not found in library I dug a little deeper and discovered that this arises from the combination of fedfs-utils' use of -Wall and -Werror and my use of almost-automake-1.11.2. Here's a better patch: >From c3f1cfcb1506126cf56717ba22abd9537321ae7a Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 30 Nov 2011 20:41:48 +0100 Subject: [PATCH] build: accommodate our use of -Wall with upcoming automake-1.11.2 * configure.ac: Using the -Wall option with what will soon be automake-1.11.2 results in a warning like this for each .a file: automake: warnings are treated as errors /usr/share/automake-1.11a/am/library.am: warning: `libadmin.a':\ linking libraries using a non-POSIX /usr/share/automake-1.11a/am/library.am: archiver requires \ `AM_PROG_AR' in `configure.ac' src/libadmin/Makefile.am:26: while processing library `libadmin.a' That is due to the -Wextra-portability option implied by -Wall. Since AM_PROG_AR is new to automake-1.11.2, for now just disable the -Wextra-portability option. Signed-off-by: Jim Meyering --- configure.ac | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) -- 1.7.8.rc4 diff --git a/configure.ac b/configure.ac index 2a2052f..b439f3f 100644 --- a/configure.ac +++ b/configure.ac @@ -34,7 +34,10 @@ AC_CONFIG_MACRO_DIR([m4]) # Automake and libtools initialization LT_INIT -AM_INIT_AUTOMAKE([-Wall -Werror silent-rules]) + +# Disable the -Wextra-portability option until developers can all use +# automake-1.11.2 or newer, at which point we'll use the new AM_PROG_AR instead. +AM_INIT_AUTOMAKE([-Wall -Werror silent-rules -Wno-extra-portability]) # configure command line options AC_ARG_WITH([fedfsuser],