Patchwork ipv4: flush route cache after change accept_local

login
register
mail settings
Submitter Peter Pan(潘卫平)
Date Dec. 2, 2011, 1:47 a.m.
Message ID <ea4d82977e7726dccd8e8f8e65c7fb523668100e.1322790334.git.panweiping3@gmail.com>
Download mbox | patch
Permalink /patch/128788/
State Accepted
Delegated to: David Miller
Headers show

Comments

Peter Pan(潘卫平) - Dec. 2, 2011, 1:47 a.m.
After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
we should flush route cache, or it will continue receive packets with local
source address, which should be dropped.

Signed-off-by: Weiping Pan <panweiping3@gmail.com>
---
 net/ipv4/devinet.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
David Miller - Dec. 2, 2011, 2:46 a.m.
From: Weiping Pan <panweiping3@gmail.com>
Date: Fri,  2 Dec 2011 09:47:06 +0800

> After reset ipv4_devconf->data[IPV4_DEVCONF_ACCEPT_LOCAL] to 0,
> we should flush route cache, or it will continue receive packets with local
> source address, which should be dropped.
> 
> Signed-off-by: Weiping Pan <panweiping3@gmail.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
index c6b5092..65f01dc 100644
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1490,7 +1490,9 @@  static int devinet_conf_proc(ctl_table *ctl, int write,
 			     void __user *buffer,
 			     size_t *lenp, loff_t *ppos)
 {
+	int old_value = *(int *)ctl->data;
 	int ret = proc_dointvec(ctl, write, buffer, lenp, ppos);
+	int new_value = *(int *)ctl->data;
 
 	if (write) {
 		struct ipv4_devconf *cnf = ctl->extra1;
@@ -1501,6 +1503,9 @@  static int devinet_conf_proc(ctl_table *ctl, int write,
 
 		if (cnf == net->ipv4.devconf_dflt)
 			devinet_copy_dflt_conf(net, i);
+		if (i == IPV4_DEVCONF_ACCEPT_LOCAL - 1)
+			if ((new_value == 0) && (old_value != 0))
+				rt_cache_flush(net, 0);
 	}
 
 	return ret;