From patchwork Thu Dec 1 22:26:12 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francois Romieu X-Patchwork-Id: 128774 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 45B0AB6F67 for ; Fri, 2 Dec 2011 09:33:18 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755368Ab1LAWcr (ORCPT ); Thu, 1 Dec 2011 17:32:47 -0500 Received: from violet.fr.zoreil.com ([92.243.8.30]:52800 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755360Ab1LAWcq (ORCPT ); Thu, 1 Dec 2011 17:32:46 -0500 Received: from violet.fr.zoreil.com (localhost [127.0.0.1]) by violet.fr.zoreil.com (8.13.8/8.13.8) with ESMTP id pB1MQDIk028032; Thu, 1 Dec 2011 23:26:13 +0100 Received: (from romieu@localhost) by violet.fr.zoreil.com (8.13.8/8.13.8/Submit) id pB1MQCwq028031; Thu, 1 Dec 2011 23:26:12 +0100 Date: Thu, 1 Dec 2011 23:26:12 +0100 From: Francois Romieu To: booster@wolke7.net Cc: hayeswang , "'Jonathan Nieder'" , "'Eric Dumazet'" , netdev@vger.kernel.org, "'nic_swsd'" , linux-kernel@vger.kernel.org, "'Armin Kazmi'" Subject: Re: [bug?] r8169: hangs under heavy load Message-ID: <20111201222612.GA27998@electric-eye.fr.zoreil.com> References: <20111126004447.GA14744@electric-eye.fr.zoreil.com> <1322280423.10212.3.camel@edumazet-laptop> <20111127092808.GE21635@elie.hsd1.il.comcast.net> <4ED2A573.1020807@wolke7.net> <20111127231147.GA1784@electric-eye.fr.zoreil.com> <20111129105440.GA2410@electric-eye.fr.zoreil.com> <4ED538EC.4010509@wolke7.net> <20111201102000.GA14013@electric-eye.fr.zoreil.com> <4ED7E6AB.6050308@wolke7.net> Mime-Version: 1.0 Content-Disposition: inline In-Reply-To: <4ED7E6AB.6050308@wolke7.net> User-Agent: Mutt/1.4.2.2i X-Organisation: Land of Sunshine Inc. Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org booster@wolke7.net : [...] > it looks OK now - no more "eth0: link up" messages and network hangs any > more. > I've send and received 60 GB to and from the system and the performance > is ~30 MB/s. > I'll keep the system up and running and do some more stability tests. Wonderful. Thanks for testing. > The only thing that's missing now is the transfer LED: the yellow link > LED is on, but the green transfer LED is off and doesn't blink. I have never looked too closely at it. You may experiment with the LEDS0 and LEDS1 bits of Config1 (no warranty). Your chipset would require it in __rtl_hw_start_8168cp - if at all. diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c index 6f06aa1..d6243a9 100644 --- a/drivers/net/ethernet/realtek/r8169.c +++ b/drivers/net/ethernet/realtek/r8169.c @@ -4602,7 +4620,7 @@ static void rtl_hw_start_8168bef(void __iomem *ioaddr, struct pci_dev *pdev) static void __rtl_hw_start_8168cp(void __iomem *ioaddr, struct pci_dev *pdev) { - RTL_W8(Config1, RTL_R8(Config1) | Speed_down); + RTL_W8(Config1, RTL_R8(Config1) | Speed_down | LEDS1); RTL_W8(Config3, RTL_R8(Config3) & ~Beacon_en);