From patchwork Tue Dec 9 00:51:24 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean MacLennan X-Patchwork-Id: 12871 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 570AC474C2 for ; Tue, 9 Dec 2008 11:53:10 +1100 (EST) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1L9qoy-0006Bh-25; Tue, 09 Dec 2008 00:51:28 +0000 Received: from toronto-hs-216-138-233-67.s-ip.magma.ca ([216.138.233.67] helo=yow.seanm.ca) by bombadil.infradead.org with smtp (Exim 4.68 #1 (Red Hat Linux)) id 1L9qov-0006Ba-R3 for linux-mtd@lists.infradead.org; Tue, 09 Dec 2008 00:51:26 +0000 Received: (qmail 12125 invoked from network); 9 Dec 2008 00:51:25 -0000 Received: from unknown (HELO lappy.seanm.ca) (192.168.0.164) by 0 with SMTP; 9 Dec 2008 00:51:25 -0000 Date: Mon, 8 Dec 2008 19:51:24 -0500 From: Sean MacLennan To: "Josh Boyer" Subject: Re: [PATCH] ndfc driver Message-ID: <20081208195124.14988307@lappy.seanm.ca> In-Reply-To: <20081204090107.20269571@zod.rchland.ibm.com> References: <20081203222832.3fc77d28@lappy.seanm.ca> <20081204090107.20269571@zod.rchland.ibm.com> Organization: PIKA X-Mailer: Claws Mail 3.6.1 (GTK+ 2.12.9; i686-pc-linux-gnu) X-Message-Flag: Warning: This message may contain actual content. Mime-Version: 1.0 X-Spam-Score: 0.1 (/) X-Spam-Report: SpamAssassin version 3.2.5 on bombadil.infradead.org summary: Content analysis details: (0.1 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.1 RDNS_DYNAMIC Delivered to trusted network by host with dynamic-looking rDNS Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.9 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org On Thu, 4 Dec 2008 09:01:07 -0500 "Josh Boyer" wrote: > You also seem to only support a single NAND chip, however the NDFC can > support multiple chips. Have you looked at how the the fsl_elbc_nand > driver does multiple chip support? If not, could you at least > document the limitation in the patch? Signed-off-by: Sean MacLennan diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c index 0352d5c..3dd85e8 100644 --- a/drivers/mtd/nand/ndfc.c +++ b/drivers/mtd/nand/ndfc.c @@ -2,11 +2,15 @@ * drivers/mtd/ndfc.c * * Overview: - * Platform independend driver for NDFC (NanD Flash Controller) + * Platform independent driver for NDFC (NanD Flash Controller) * integrated into EP440 cores * * Ported to an OF platform driver by Sean MacLennan * + * The NDFC supports multiple chips, but this driver only supports a + * single chip since I do not have access to any boards with + * multiple chips. + * * Author: Thomas Gleixner * * Copyright 2006 IBM