Patchwork MTD: nand: Convert au1550nd to use module_platform_driver()

login
register
mail settings
Submitter Axel Lin
Date Dec. 1, 2011, 2:04 p.m.
Message ID <1322748247.31743.1.camel@phoenix>
Download mbox | patch
Permalink /patch/128703/
State New
Headers show

Comments

Axel Lin - Dec. 1, 2011, 2:04 p.m.
Cc: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Hi Ralf,
This patch converts au1550nd to use module_platform_driver().
You have committed a5bd32fd "MTD: nand: make au1550nd.c a platform_driver".
Currently this patch can only apply to either your tree or linux-next.
Could you help to take it.
( committed a5bd32fd does not exist in l2-mtd-2.6.git,
so Artem cannot apply it.)

Thanks,
Axel

 drivers/mtd/nand/au1550nd.c |   12 +-----------
 1 files changed, 1 insertions(+), 11 deletions(-)
Artem Bityutskiy - Dec. 4, 2011, 2:15 p.m.
On Thu, 2011-12-01 at 22:04 +0800, Axel Lin wrote:
> Cc: Manuel Lauss <manuel.lauss@googlemail.com>
> Cc: Artem Bityutskiy <dedekind1@gmail.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> Hi Ralf,
> This patch converts au1550nd to use module_platform_driver().
> You have committed a5bd32fd "MTD: nand: make au1550nd.c a platform_driver".
> Currently this patch can only apply to either your tree or linux-next.
> Could you help to take it.
> ( committed a5bd32fd does not exist in l2-mtd-2.6.git,
> so Artem cannot apply it.)

Yes, please, merge the au1550nd.c piece via Ralf, thanks!
Ralf Baechle - Dec. 8, 2011, 10:45 a.m.
On Sun, Dec 04, 2011 at 04:15:32PM +0200, Artem Bityutskiy wrote:

> > Hi Ralf,
> > This patch converts au1550nd to use module_platform_driver().
> > You have committed a5bd32fd "MTD: nand: make au1550nd.c a platform_driver".
> > Currently this patch can only apply to either your tree or linux-next.
> > Could you help to take it.
> > ( committed a5bd32fd does not exist in l2-mtd-2.6.git,
> > so Artem cannot apply it.)
> 
> Yes, please, merge the au1550nd.c piece via Ralf, thanks!

No point in adding code to change it again first commit so I've folded
this patch into "MTD: nand: make au1550nd.c a platform_driver".

Thanks folks!

  Ralf

Patch

diff --git a/drivers/mtd/nand/au1550nd.c b/drivers/mtd/nand/au1550nd.c
index 77fb4e6..73abbc3 100644
--- a/drivers/mtd/nand/au1550nd.c
+++ b/drivers/mtd/nand/au1550nd.c
@@ -560,17 +560,7 @@  static struct platform_driver au1550nd_driver = {
 	.remove		= __devexit_p(au1550nd_remove),
 };
 
-static int __init au1550nd_load(void)
-{
-	return platform_driver_register(&au1550nd_driver);
-};
-
-static void __exit au1550nd_exit(void)
-{
-	platform_driver_unregister(&au1550nd_driver);
-};
-module_init(au1550nd_load);
-module_exit(au1550nd_exit);
+module_platform_driver(au1550nd_driver);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Embedded Edge, LLC");