From patchwork Thu Dec 1 12:27:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,5/8] mount: don't leak upon LDAP parse failure Date: Thu, 01 Dec 2011 02:27:16 -0000 From: Jim Meyering X-Patchwork-Id: 128693 Message-Id: <1322742439-2171-6-git-send-email-jim@meyering.net> To: fedfs-utils-devel@oss.oracle.com From: Jim Meyering * src/libnsdb/fileserver.c (nsdb_resolve_fsn_parse_entry): When we fail to parse an LDAP entry, free just-allocated new->fl_dn and new. Spotted by coverity. Signed-off-by: Jim Meyering --- src/libnsdb/fileserver.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/libnsdb/fileserver.c b/src/libnsdb/fileserver.c index a7631e8..b22d83f 100644 --- a/src/libnsdb/fileserver.c +++ b/src/libnsdb/fileserver.c @@ -781,6 +781,8 @@ nsdb_resolve_fsn_parse_entry(LDAP *ld, LDAPMessage *entry, if (retval != FEDFS_OK) { xlog(D_CALL, "%s: parsing failed: %s", __func__, nsdb_display_fedfsstatus(retval)); + free(new->fl_dn); + free(new); return retval; }