Patchwork [U-Boot] x86: Turn on support for EFI's GPT in the coreboot config

login
register
mail settings
Submitter Gabe Black
Date Nov. 29, 2011, 6:57 a.m.
Message ID <1322549828-22954-1-git-send-email-gabeblack@chromium.org>
Download mbox | patch
Permalink /patch/128228/
State Superseded, archived
Delegated to: Simon Glass
Headers show

Comments

Gabe Black - Nov. 29, 2011, 6:57 a.m.
This allows u-boot to figure out the partitions of a chrome-os install.

Signed-off-by: Gabe Black <gabeblack@chromium.org>
---
 include/configs/coreboot.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Graeme Russ - Nov. 29, 2011, 10:58 a.m.
Hi Gabe,

On 29/11/11 17:57, Gabe Black wrote:
> This allows u-boot to figure out the partitions of a chrome-os install.
> 
> Signed-off-by: Gabe Black <gabeblack@chromium.org>
> ---
>  include/configs/coreboot.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
> index 348a25b..e98201d 100644
> --- a/include/configs/coreboot.h
> +++ b/include/configs/coreboot.h
> @@ -89,6 +89,7 @@
>  /************************************************************
>   * DISK Partition support
>   ************************************************************/
> +#define CONFIG_EFI_PARTITION
>  #define CONFIG_DOS_PARTITION
>  #define CONFIG_MAC_PARTITION
>  #define CONFIG_ISO_PARTITION		/* Experimental */

Since "x86: Initial commit for running as a coreboot payload" has not been
applied yet, is there any reason this (and "x86: Fix IDE configuration for
the coreboot board") could not be merged into it?

Regards,

Graeme
Gabe Black - Nov. 29, 2011, 8:07 p.m.
No, that would be fine.

Gabe

On Tue, Nov 29, 2011 at 2:58 AM, Graeme Russ <graeme.russ@gmail.com> wrote:

> Hi Gabe,
>
> On 29/11/11 17:57, Gabe Black wrote:
> > This allows u-boot to figure out the partitions of a chrome-os install.
> >
> > Signed-off-by: Gabe Black <gabeblack@chromium.org>
> > ---
> >  include/configs/coreboot.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
> > index 348a25b..e98201d 100644
> > --- a/include/configs/coreboot.h
> > +++ b/include/configs/coreboot.h
> > @@ -89,6 +89,7 @@
> >  /************************************************************
> >   * DISK Partition support
> >   ************************************************************/
> > +#define CONFIG_EFI_PARTITION
> >  #define CONFIG_DOS_PARTITION
> >  #define CONFIG_MAC_PARTITION
> >  #define CONFIG_ISO_PARTITION         /* Experimental */
>
> Since "x86: Initial commit for running as a coreboot payload" has not been
> applied yet, is there any reason this (and "x86: Fix IDE configuration for
> the coreboot board") could not be merged into it?
>
> Regards,
>
> Graeme
>
Graeme Russ - Nov. 29, 2011, 9:58 p.m.
Hi Gabe,

On Wed, Nov 30, 2011 at 7:07 AM, Gabe Black <gabeblack@google.com> wrote:
> No, that would be fine.

OK, can you send an updated patch - I'll apply it to u-boot-x86/next

Regards,

Graeme

>
> Gabe
>
>
> On Tue, Nov 29, 2011 at 2:58 AM, Graeme Russ <graeme.russ@gmail.com> wrote:
>>
>> Hi Gabe,
>>
>> On 29/11/11 17:57, Gabe Black wrote:
>> > This allows u-boot to figure out the partitions of a chrome-os install.
>> >
>> > Signed-off-by: Gabe Black <gabeblack@chromium.org>
>> > ---
>> >  include/configs/coreboot.h |    1 +
>> >  1 files changed, 1 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
>> > index 348a25b..e98201d 100644
>> > --- a/include/configs/coreboot.h
>> > +++ b/include/configs/coreboot.h
>> > @@ -89,6 +89,7 @@
>> >  /************************************************************
>> >   * DISK Partition support
>> >   ************************************************************/
>> > +#define CONFIG_EFI_PARTITION
>> >  #define CONFIG_DOS_PARTITION
>> >  #define CONFIG_MAC_PARTITION
>> >  #define CONFIG_ISO_PARTITION         /* Experimental */
>>
>> Since "x86: Initial commit for running as a coreboot payload" has not been
>> applied yet, is there any reason this (and "x86: Fix IDE configuration for
>> the coreboot board") could not be merged into it?
>>
>> Regards,
>>
>> Graeme
>
>
Gabe Black - Nov. 29, 2011, 11:44 p.m.
Actually, I found some compile errors in the upstream EFI support. The
patch I'll be sending out soon should be applied before this one so
everything still builds.

Gabe

On Tue, Nov 29, 2011 at 1:58 PM, Graeme Russ <graeme.russ@gmail.com> wrote:

> Hi Gabe,
>
> On Wed, Nov 30, 2011 at 7:07 AM, Gabe Black <gabeblack@google.com> wrote:
> > No, that would be fine.
>
> OK, can you send an updated patch - I'll apply it to u-boot-x86/next
>
> Regards,
>
> Graeme
>
> >
> > Gabe
> >
> >
> > On Tue, Nov 29, 2011 at 2:58 AM, Graeme Russ <graeme.russ@gmail.com>
> wrote:
> >>
> >> Hi Gabe,
> >>
> >> On 29/11/11 17:57, Gabe Black wrote:
> >> > This allows u-boot to figure out the partitions of a chrome-os
> install.
> >> >
> >> > Signed-off-by: Gabe Black <gabeblack@chromium.org>
> >> > ---
> >> >  include/configs/coreboot.h |    1 +
> >> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >> >
> >> > diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
> >> > index 348a25b..e98201d 100644
> >> > --- a/include/configs/coreboot.h
> >> > +++ b/include/configs/coreboot.h
> >> > @@ -89,6 +89,7 @@
> >> >  /************************************************************
> >> >   * DISK Partition support
> >> >   ************************************************************/
> >> > +#define CONFIG_EFI_PARTITION
> >> >  #define CONFIG_DOS_PARTITION
> >> >  #define CONFIG_MAC_PARTITION
> >> >  #define CONFIG_ISO_PARTITION         /* Experimental */
> >>
> >> Since "x86: Initial commit for running as a coreboot payload" has not
> been
> >> applied yet, is there any reason this (and "x86: Fix IDE configuration
> for
> >> the coreboot board") could not be merged into it?
> >>
> >> Regards,
> >>
> >> Graeme
> >
> >
>

Patch

diff --git a/include/configs/coreboot.h b/include/configs/coreboot.h
index 348a25b..e98201d 100644
--- a/include/configs/coreboot.h
+++ b/include/configs/coreboot.h
@@ -89,6 +89,7 @@ 
 /************************************************************
  * DISK Partition support
  ************************************************************/
+#define CONFIG_EFI_PARTITION
 #define CONFIG_DOS_PARTITION
 #define CONFIG_MAC_PARTITION
 #define CONFIG_ISO_PARTITION		/* Experimental */