From patchwork Tue Nov 29 05:37:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sheldon X-Patchwork-Id: 128217 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 01BDF1007D3 for ; Tue, 29 Nov 2011 16:37:50 +1100 (EST) Received: from localhost ([::1]:45754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVGO3-0002sI-5C for incoming@patchwork.ozlabs.org; Tue, 29 Nov 2011 00:37:47 -0500 Received: from eggs.gnu.org ([140.186.70.92]:56468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVGNx-0002sB-Iv for qemu-devel@nongnu.org; Tue, 29 Nov 2011 00:37:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVGNw-00023Y-8S for qemu-devel@nongnu.org; Tue, 29 Nov 2011 00:37:41 -0500 Received: from e23smtp03.au.ibm.com ([202.81.31.145]:40949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVGNv-000232-3a for qemu-devel@nongnu.org; Tue, 29 Nov 2011 00:37:40 -0500 Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 29 Nov 2011 05:32:07 +1000 Received: from d23relay03.au.ibm.com ([202.81.31.245]) by e23smtp03.au.ibm.com ([202.81.31.209]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 29 Nov 2011 05:31:57 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAT5bBLr5005446 for ; Tue, 29 Nov 2011 16:37:14 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAT5bBq7029897 for ; Tue, 29 Nov 2011 16:37:11 +1100 Received: from [9.115.122.206] (fsh-thinkpad-t410.cn.ibm.com [9.115.122.206] (may be forged)) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pAT5bAqD029836; Tue, 29 Nov 2011 16:37:10 +1100 Message-ID: <4ED46F85.4090101@linux.vnet.ibm.com> Date: Tue, 29 Nov 2011 13:37:09 +0800 From: ShaoHe Feng User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110929 Thunderbird/7.0.1 MIME-Version: 1.0 To: Liu Ping Fan References: <1322188529-11609-1-git-send-email-kernelfans@gmail.com> <1322361937-22438-4-git-send-email-kernelfans@gmail.com> In-Reply-To: <1322361937-22438-4-git-send-email-kernelfans@gmail.com> x-cbid: 11112819-6102-0000-0000-000000482528 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.81.31.145 Cc: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 4/5] QEMU Release vcpu and finally exit vcpu thread safely X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Ping Fan, IMO, QEMU should Release vcpu and finally exit vcpu thread safely in tcg mode? --- cpus.c | 21 ++++++++++++++++++++- 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/cpus.c b/cpus.c index 82530c4..cc52327 100644 --- a/cpus.c +++ b/cpus.c @@ -753,7 +753,7 @@ static void tcg_exec_all(void); static void *qemu_tcg_cpu_thread_fn(void *arg) { CPUState *env = arg; - + CPUState *prev = NULL; qemu_tcg_init_cpu_signals(); qemu_thread_get_self(env->thread); @@ -775,10 +775,29 @@ static void *qemu_tcg_cpu_thread_fn(void *arg) if (use_icount && qemu_clock_deadline(vm_clock) <= 0) { qemu_notify_event(); } + /*1,try to zap; 2, can safe to destroy*/ + if (env->state == CPU_STATE_ZAPPED) { + goto zapout; + } qemu_tcg_wait_io_event(); } return NULL; +zapout: + prev = first_cpu; + if (prev == env) { + first_cpu = env->next_cpu; + } else { + while (prev != NULL) { + if (prev->next_cpu == env) { + break; + } + prev = prev->next_cpu; + } + prev->next_cpu = env->next_cpu; + } + cpu_free(env); + return NULL; } static void qemu_cpu_kick_thread(CPUState *env)