From patchwork Mon Nov 28 18:11:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 128051 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 19EAEB6F85 for ; Tue, 29 Nov 2011 05:35:47 +1100 (EST) Received: from localhost ([::1]:54978 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV63H-00041b-CC for incoming@patchwork.ozlabs.org; Mon, 28 Nov 2011 13:35:39 -0500 Received: from eggs.gnu.org ([140.186.70.92]:55931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV5iI-0006v9-Vb for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:14:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RV5iC-0000Li-63 for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:13:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RV5gB-0008Ee-4C for qemu-devel@nongnu.org; Mon, 28 Nov 2011 13:11:47 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pASIBiMN011448 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 Nov 2011 13:11:44 -0500 Received: from localhost (ovpn-113-91.phx2.redhat.com [10.3.113.91]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pASIBhSQ028399; Mon, 28 Nov 2011 13:11:44 -0500 From: Luiz Capitulino To: qemu-devel@nongnu.org Date: Mon, 28 Nov 2011 16:11:16 -0200 Message-Id: <1322503885-5913-8-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1322503885-5913-1-git-send-email-lcapitulino@redhat.com> References: <1322503885-5913-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com Subject: [Qemu-devel] [PATCH 07/16] qapi: Convert inject-nmi X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Luiz Capitulino --- cpus.c | 13 +++++++++++++ hmp-commands.hx | 3 +-- hmp.c | 8 ++++++++ hmp.h | 1 + monitor.c | 19 ------------------- qapi-schema.json | 13 +++++++++++++ qmp-commands.hx | 5 +---- 7 files changed, 37 insertions(+), 25 deletions(-) diff --git a/cpus.c b/cpus.c index 72ab6f5..b7acbb9 100644 --- a/cpus.c +++ b/cpus.c @@ -1212,3 +1212,16 @@ void qmp_pmemsave(int64_t addr, int64_t size, const char *filename, exit: fclose(f); } + +void qmp_inject_nmi(Error **errp) +{ +#if defined(TARGET_I386) + CPUState *env; + + for (env = first_cpu; env != NULL; env = env->next_cpu) { + cpu_interrupt(env, CPU_INTERRUPT_NMI); + } +#else + error_set(errp, QERR_UNSUPPORTED); +#endif +} diff --git a/hmp-commands.hx b/hmp-commands.hx index bbfa9c4..fff39ea 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -736,8 +736,7 @@ ETEXI .args_type = "", .params = "", .help = "inject an NMI on all guest's CPUs", - .user_print = monitor_user_noop, - .mhandler.cmd_new = do_inject_nmi, + .mhandler.cmd = hmp_inject_nmi, }, #endif STEXI diff --git a/hmp.c b/hmp.c index a82cb52..fbd55c6 100644 --- a/hmp.c +++ b/hmp.c @@ -583,3 +583,11 @@ void hmp_cont(Monitor *mon, const QDict *qdict) hmp_handle_error(mon, &errp); } } + +void hmp_inject_nmi(Monitor *mon, const QDict *qdict) +{ + Error *errp = NULL; + + qmp_inject_nmi(&errp); + hmp_handle_error(mon, &errp); +} diff --git a/hmp.h b/hmp.h index b034704..8a31f87 100644 --- a/hmp.h +++ b/hmp.h @@ -40,5 +40,6 @@ void hmp_cpu(Monitor *mon, const QDict *qdict); void hmp_memsave(Monitor *mon, const QDict *qdict); void hmp_pmemsave(Monitor *mon, const QDict *qdict); void hmp_cont(Monitor *mon, const QDict *qdict); +void hmp_inject_nmi(Monitor *mon, const QDict *qdict); #endif diff --git a/monitor.c b/monitor.c index b0d1862..62b1747 100644 --- a/monitor.c +++ b/monitor.c @@ -2204,25 +2204,6 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict) } #endif -#if defined(TARGET_I386) -static int do_inject_nmi(Monitor *mon, const QDict *qdict, QObject **ret_data) -{ - CPUState *env; - - for (env = first_cpu; env != NULL; env = env->next_cpu) { - cpu_interrupt(env, CPU_INTERRUPT_NMI); - } - - return 0; -} -#else -static int do_inject_nmi(Monitor *mon, const QDict *qdict, QObject **ret_data) -{ - qerror_report(QERR_UNSUPPORTED); - return -1; -} -#endif - static qemu_acl *find_acl(Monitor *mon, const char *name) { qemu_acl *acl = qemu_acl_find(name); diff --git a/qapi-schema.json b/qapi-schema.json index 1d312e0..a7f11be 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -952,3 +952,16 @@ ## { 'command': 'cont' } +## +# @inject-nmi: +# +# Injects an Non-Maskable Interrupt into all guest's VCPUs. +# +# Returns: If successful, nothing +# If the Virtual Machine doesn't support NMI injection, Unsupported +# +# Since: 0.14.0 +# +# Notes: Only x86 Virtual Machines support this command. +## +{ 'command': 'inject-nmi' } diff --git a/qmp-commands.hx b/qmp-commands.hx index 1f5109c..ff0b801 100644 --- a/qmp-commands.hx +++ b/qmp-commands.hx @@ -407,10 +407,7 @@ EQMP { .name = "inject-nmi", .args_type = "", - .params = "", - .help = "", - .user_print = monitor_user_noop, - .mhandler.cmd_new = do_inject_nmi, + .mhandler.cmd_new = qmp_marshal_input_inject_nmi, }, SQMP