Patchwork [net-next,7/8] net: Revert ARCNET and PHYLIB to tristate options

login
register
mail settings
Submitter Ben Hutchings
Date Nov. 26, 2011, 12:40 a.m.
Message ID <1322268002.2839.390.camel@deadeye>
Download mbox | patch
Permalink /patch/127768/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Nov. 26, 2011, 12:40 a.m.
commit 88491d8103498a6166f70d5999902fec70924314 ("drivers/net: Kconfig
& Makefile cleanup") changed the type of these options to bool, but
they select code that could (and still can) be built as modules.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
Yes David, they do still build this way.  Even in an allmodconfig
configuration, now.  And I still really want this in net.

Ben.

 drivers/net/arcnet/Kconfig |    2 +-
 drivers/net/phy/Kconfig    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
David Miller - Nov. 26, 2011, 7:42 p.m.
From: Ben Hutchings <ben@decadent.org.uk>
Date: Sat, 26 Nov 2011 00:40:02 +0000

> commit 88491d8103498a6166f70d5999902fec70924314 ("drivers/net: Kconfig
> & Makefile cleanup") changed the type of these options to bool, but
> they select code that could (and still can) be built as modules.
> 
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> Yes David, they do still build this way.  Even in an allmodconfig
> configuration, now.  And I still really want this in net.

Color me extremely impressed.

Ok, I'll put this into 'net', pull it into 'net-next', then apply the
rest of this series there.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/arcnet/Kconfig b/drivers/net/arcnet/Kconfig
index a73d9dc..84fb634 100644
--- a/drivers/net/arcnet/Kconfig
+++ b/drivers/net/arcnet/Kconfig
@@ -4,7 +4,7 @@ 
 
 menuconfig ARCNET
 	depends on NETDEVICES && (ISA || PCI || PCMCIA)
-	bool "ARCnet support"
+	tristate "ARCnet support"
 	---help---
 	  If you have a network card of this type, say Y and check out the
 	  (arguably) beautiful poetry in
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index bb88e12..a702443 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -3,7 +3,7 @@ 
 #
 
 menuconfig PHYLIB
-	bool "PHY Device support and infrastructure"
+	tristate "PHY Device support and infrastructure"
 	depends on !S390
 	depends on NETDEVICES
 	help