From patchwork Fri Nov 25 17:44:54 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Igor_Maravi=C4=87?= X-Patchwork-Id: 127730 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6B6571007D5 for ; Sat, 26 Nov 2011 04:45:21 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320Ab1KYRpO (ORCPT ); Fri, 25 Nov 2011 12:45:14 -0500 Received: from mx1.etf.rs ([147.91.14.169]:58525 "EHLO mx1.etf.bg.ac.rs" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752947Ab1KYRpL (ORCPT ); Fri, 25 Nov 2011 12:45:11 -0500 Received: from localhost (avs1.etf.rs [147.91.14.172]) by mx1.etf.bg.ac.rs (Postfix) with ESMTP id 60C4212012D; Fri, 25 Nov 2011 18:45:10 +0100 (CET) X-Virus-Scanned: amavisd-new at etf.rs Received: from mx2.etf.bg.ac.rs ([147.91.14.170]) by localhost (avs1.etf.rs [147.91.14.171]) (amavisd-new, port 10026) with ESMTP id GYkbIt7RnrWC; Fri, 25 Nov 2011 18:45:09 +0100 (CET) Received: from igor-PC.etf.bg.ac.rs (dhcp21.etf.bg.ac.rs [147.91.9.150]) by mx2.etf.bg.ac.rs (Postfix) with ESMTP id AF34F60142; Fri, 25 Nov 2011 18:45:09 +0100 (CET) From: igorm@etf.rs To: netdev@vger.kernel.org Cc: Igor Maravic Subject: [PATCH] Fix skb_update_prio Date: Fri, 25 Nov 2011 18:44:54 +0100 Message-Id: <1322243094-10420-2-git-send-email-igorm@etf.rs> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1322243094-10420-1-git-send-email-igorm@etf.rs> References: <1322243094-10420-1-git-send-email-igorm@etf.rs> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Igor Maravic Change function rcu_dereference to rcu_dereference_bh to avoid warning [ INFO: suspicious RCU usage. ] ------------------------------- net/core/dev.c:2459 suspicious rcu_dereference_check() usage! because we are locking with rcu_read_lock_bh(); in function dev_queue_xmit(struct sk_buff *skb) Signed-off-by: Igor Maravic --- net/core/dev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/dev.c b/net/core/dev.c index 8afb244..d1f1071 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2452,7 +2452,7 @@ static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q, #if IS_ENABLED(CONFIG_NETPRIO_CGROUP) static void skb_update_prio(struct sk_buff *skb) { - struct netprio_map *map = rcu_dereference(skb->dev->priomap); + struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap); if ((!skb->priority) && (skb->sk) && map) skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];