Patchwork Fix skb_update_prio

login
register
mail settings
Submitter Igor Maravić
Date Nov. 25, 2011, 5:44 p.m.
Message ID <1322243094-10420-2-git-send-email-igorm@etf.rs>
Download mbox | patch
Permalink /patch/127730/
State Accepted
Delegated to: David Miller
Headers show

Comments

Igor Maravić - Nov. 25, 2011, 5:44 p.m.
From: Igor Maravic <igorm@etf.rs>

Change function rcu_dereference to rcu_dereference_bh to avoid warning

[ INFO: suspicious RCU usage. ]
-------------------------------
net/core/dev.c:2459 suspicious rcu_dereference_check() usage!

because we are locking with

rcu_read_lock_bh();

in function dev_queue_xmit(struct sk_buff *skb)

Signed-off-by: Igor Maravic <igorm@etf.rs>
---
 net/core/dev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Nov. 29, 2011, 11:25 p.m.
From: igorm@etf.rs
Date: Fri, 25 Nov 2011 18:44:54 +0100

> From: Igor Maravic <igorm@etf.rs>
> 
> Change function rcu_dereference to rcu_dereference_bh to avoid warning
> 
> [ INFO: suspicious RCU usage. ]
> -------------------------------
> net/core/dev.c:2459 suspicious rcu_dereference_check() usage!
> 
> because we are locking with
> 
> rcu_read_lock_bh();
> 
> in function dev_queue_xmit(struct sk_buff *skb)
> 
> Signed-off-by: Igor Maravic <igorm@etf.rs>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/core/dev.c b/net/core/dev.c
index 8afb244..d1f1071 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2452,7 +2452,7 @@  static inline int __dev_xmit_skb(struct sk_buff *skb, struct Qdisc *q,
 #if IS_ENABLED(CONFIG_NETPRIO_CGROUP)
 static void skb_update_prio(struct sk_buff *skb)
 {
-	struct netprio_map *map = rcu_dereference(skb->dev->priomap);
+	struct netprio_map *map = rcu_dereference_bh(skb->dev->priomap);
 
 	if ((!skb->priority) && (skb->sk) && map)
 		skb->priority = map->priomap[skb->sk->sk_cgrp_prioidx];