From patchwork Thu Nov 24 23:06:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikael Morin X-Patchwork-Id: 127626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7A1F51007DA for ; Fri, 25 Nov 2011 10:08:09 +1100 (EST) Received: (qmail 19732 invoked by alias); 24 Nov 2011 23:08:07 -0000 Received: (qmail 19717 invoked by uid 22791); 24 Nov 2011 23:08:06 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp21.services.sfr.fr (HELO smtp21.services.sfr.fr) (93.17.128.4) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 24 Nov 2011 23:07:53 +0000 Received: from filter.sfr.fr (localhost [127.0.0.1]) by msfrf2114.sfr.fr (SMTP Server) with ESMTP id 662627000058; Fri, 25 Nov 2011 00:07:52 +0100 (CET) Received: from marvin.localnet (61.15.72.86.rev.sfr.net [86.72.15.61]) by msfrf2114.sfr.fr (SMTP Server) with ESMTP id 421567000047; Fri, 25 Nov 2011 00:07:52 +0100 (CET) X-SFR-UUID: 20111124230752270.421567000047@msfrf2114.sfr.fr From: Mikael Morin To: fortran@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: [Patch, fortran] coarray cleanup leftover Date: Fri, 25 Nov 2011 00:06:08 +0100 User-Agent: KMail/1.13.7 (Linux/2.6.39-gentoo-r3-mik3; KDE/4.6.5; x86_64; ; ) MIME-Version: 1.0 X-UID: 330 Message-Id: <201111250006.08939.mikael.morin@sfr.fr> X-sfr-mailing: LEGIT X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, This change http://gcc.gnu.org/viewcvs?view=revision&revision=179689 removed references to gfc_loopinfo's codimen field and one conditional checking against gfc_loopinfo::dimen (as we had the convention that dimensions above dimen were codimensions). I have noticed two more of those conditionals which I'm proposing for removal. This is not a bug nor a regression, so this should normally wait for the next stage1. It is obvious on the other hand, and safe, as the 'n < loop->dimen' conditions are inside a 'for (n = 0; n < loop->dimen; n++)' loop. Regression tested on x86_64-unknown-linux-gnu (with the just posted pr51250 patch). OK for trunk? Mikael 2011-11-24 Mikael Morin * trans-array.c (set_loop_bounds): Remove dead conditions. diff --git a/gcc/fortran/trans-array.c b/gcc/fortran/trans-array.c index 2fb2d34..ee8f896 100644 --- a/gcc/fortran/trans-array.c +++ b/gcc/fortran/trans-array.c @@ -4341,9 +4341,9 @@ set_loop_bounds (gfc_loopinfo *loop) } /* Transform everything so we have a simple incrementing variable. */ - if (n < loop->dimen && integer_onep (info->stride[dim])) + if (integer_onep (info->stride[dim])) info->delta[dim] = gfc_index_zero_node; - else if (n < loop->dimen) + else { /* Set the delta for this section. */ info->delta[dim] = gfc_evaluate_now (loop->from[n], &loop->pre);