Patchwork cannot build qemu with "--static" configure option

login
register
mail settings
Submitter Max Filippov
Date Nov. 23, 2011, 9:40 p.m.
Message ID <201111240140.08335.jcmvbkbc@gmail.com>
Download mbox | patch
Permalink /patch/127395/
State New
Headers show

Comments

Max Filippov - Nov. 23, 2011, 9:40 p.m.
> > Did configure reported 'usb net redir' as 'no'?
> > Could you try configure and build in a clean directory?
> [mr-4@test1 qemu-1.0-rc3]$ ./configure --target-list="arm-linux-user armeb-linux-user" --disable-kvm --disable-strip --disable-xen --disable-spice --disable-werror --disable-sdl --disable-vnc --disable-bluez --disable-check-utests --disable-smartcard --disable-usb-redir --static
...
> usb net redir     yes
> OpenGL support    no
> libiscsi support  no
> build guest agent yes
> 
> This is utterly bizarre! Why is "usb net redir" set as "yes" I have no idea!
> 

Could you try configure with the following patch?


Thanks.
-- Max
Peter Maydell - Nov. 23, 2011, 10:12 p.m.
On 23 November 2011 21:40, Max Filippov <jcmvbkbc@gmail.com> wrote:
> --- a/configure
> +++ b/configure
> @@ -759,8 +759,6 @@ for opt do
>   ;;
>   --enable-opengl) opengl="yes"
>   ;;
> -  --*dir)
> -  ;;
>   --disable-rbd) rbd="no"
>   ;;
>   --enable-rbd) rbd="yes"

Haha, nice catch. Incidentally I think that the proper fix for this
should be to have a case statement that explicitly matches for the
--thingydir options we accept, and drop the wildcard completely.

-- PMM

Patch

diff --git a/configure b/configure
index f033438..e5566c8 100755
--- a/configure
+++ b/configure
@@ -759,8 +759,6 @@  for opt do
   ;;
   --enable-opengl) opengl="yes"
   ;;
-  --*dir)
-  ;;
   --disable-rbd) rbd="no"
   ;;
   --enable-rbd) rbd="yes"
@@ -783,6 +781,8 @@  for opt do
   ;;
   --disable-guest-agent) guest_agent="no"
   ;;
+  --*dir)
+  ;;
   *) echo "ERROR: unknown option $opt"; show_help="yes"
   ;;
   esac