Patchwork mtd: gpmi: add missing include 'module.h'

login
register
mail settings
Submitter Wolfram Sang
Date Nov. 23, 2011, 2:57 p.m.
Message ID <1322060226-5208-1-git-send-email-w.sang@pengutronix.de>
Download mbox | patch
Permalink /patch/127318/
State Accepted
Commit df16c86a56595d1c28e58532ec25dd612c39c6c7
Headers show

Comments

Wolfram Sang - Nov. 23, 2011, 2:57 p.m.
Fixes:

drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'

and some more...

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Huang Shijie - Nov. 24, 2011, 3:01 a.m.
Hi Wolfram:

The ARCH part of the GPMI is not merged into mainline now.
I do not know why it can not be accepted. :(

How did compile the GPMI driver in such situation?

Best Regards
Huang Shijie
> Fixes:
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>
> and some more...
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>
>  #include <linux/mtd/partitions.h>
> -
>  #include "gpmi-nand.h"
>  
>  /* add our owner bbt descriptor */
Wolfram Sang - Nov. 24, 2011, 7:53 a.m.
> The ARCH part of the GPMI is not merged into mainline now.
> I do not know why it can not be accepted. :(

Just resend it; this is quite normal, we are all too busy :/

> How did compile the GPMI driver in such situation?

I applied the arch-party manually.
Huang Shijie - Nov. 24, 2011, 8:58 a.m.
于 2011年11月23日 22:57, Wolfram Sang 写道:
> Fixes:
>
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
>
> and some more...
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>
>  #include <linux/mtd/partitions.h>
> -
>  #include "gpmi-nand.h"
>  
>  /* add our owner bbt descriptor */
Acked-by: Huang Shijie <b32955@freescale.com>
Artem Bityutskiy - Nov. 29, 2011, 10:20 p.m.
On Wed, 2011-11-23 at 15:57 +0100, Wolfram Sang wrote:
> Fixes:
> 
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'

Pushed to l2-mtd-2.6.git, thanks!

Artem.
Marek Vasut - Dec. 2, 2011, 7:47 p.m.
> Fixes:
> 
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE'
> undeclared (first use in this function)
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared
> identifier is reported only once for each function it appears in
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration
> specifiers or '...' before string constant
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition
> has no type or storage class
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to
> 'int' in declaration of 'MODULE_AUTHOR'
> 
> and some more...
> 
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 071b634..493ec2f 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -21,9 +21,9 @@
>  #include <linux/clk.h>
>  #include <linux/slab.h>
>  #include <linux/interrupt.h>
> +#include <linux/module.h>
>  #include <linux/mtd/gpmi-nand.h>

This one is missing too, but I suspect that's the stuff discussed in the 
subsequent emails? When do you plan to get this merged? (or what do I need to 
apply by hand ... patch name or message ID is ok).

Thanks

M
Artem Bityutskiy - Dec. 5, 2011, 6:34 a.m.
On Fri, 2011-12-02 at 20:47 +0100, Marek Vasut wrote:
> This one is missing too, but I suspect that's the stuff discussed in the 
> subsequent emails? When do you plan to get this merged? (or what do I need to 
> apply by hand ... patch name or message ID is ok).

Ah, right, this should be merged ASAP. Let's ask David to merge this
patch from my l2-mtd-2.6.git tree:

commit 63c646f21ef5bcde88a81b2695a450c4665857d4
Author: Wolfram Sang <w.sang@pengutronix.de>
Date:   Wed Nov 23 15:57:06 2011 +0100

    mtd: gpmi: add missing include 'module.h'
    
    Fixes:
    
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE' undeclared (first use in this function)
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared identifier is reported only once for each function it appears in
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected declaration specifiers or '...' before string constant
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition has no type or storage class
    drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to 'int' in declaration of 'MODULE_AUTHOR'
    
    and some more...
    
    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    Acked-by: Huang Shijie <b32955@freescale.com>
    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@intel.com>

Artem.
Marek Vasut - Dec. 13, 2011, 10:15 p.m.
> > Fixes:
> > 
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c: In function 'gpmi_nfc_init':
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: error: 'THIS_MODULE'
> > undeclared (first use in this function)
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1475:16: note: each undeclared
> > identifier is reported only once for each function it appears in
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c: At top level:
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:15: error: expected
> > declaration specifiers or '...' before string constant
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: data definition
> > has no type or storage class
> > drivers/mtd/nand/gpmi-nand/gpmi-nand.c:1617:1: warning: type defaults to
> > 'int' in declaration of 'MODULE_AUTHOR'
> > 
> > and some more...
> > 
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > ---
> > 
> >  drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c index 071b634..493ec2f 100644
> > --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> > @@ -21,9 +21,9 @@
> > 
> >  #include <linux/clk.h>
> >  #include <linux/slab.h>
> >  #include <linux/interrupt.h>
> > 
> > +#include <linux/module.h>
> > 
> >  #include <linux/mtd/gpmi-nand.h>
> 
> This one is missing too, but I suspect that's the stuff discussed in the
> subsequent emails? When do you plan to get this merged? (or what do I need
> to apply by hand ... patch name or message ID is ok).
> 
> Thanks
> 
> M

BUMP

any updates?
Thanks

M
Artem Bityutskiy - Dec. 17, 2011, 3:54 p.m.
On Tue, 2011-12-13 at 23:15 +0100, Marek Vasut wrote:
> BUMP

Ping David Woodhouse, it is his turn not send this to Linus.
Marek Vasut - Dec. 17, 2011, 11:19 p.m.
> On Tue, 2011-12-13 at 23:15 +0100, Marek Vasut wrote:
> > BUMP
> 
> Ping David Woodhouse, it is his turn not send this to Linus.

Adding him to Cc

M

Patch

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 071b634..493ec2f 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -21,9 +21,9 @@ 
 #include <linux/clk.h>
 #include <linux/slab.h>
 #include <linux/interrupt.h>
+#include <linux/module.h>
 #include <linux/mtd/gpmi-nand.h>
 #include <linux/mtd/partitions.h>
-
 #include "gpmi-nand.h"
 
 /* add our owner bbt descriptor */