From patchwork Wed Nov 23 12:32:29 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Javier Martin X-Patchwork-Id: 127294 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 68A55B70B7 for ; Wed, 23 Nov 2011 23:35:04 +1100 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1RTC0C-0002fm-9v; Wed, 23 Nov 2011 12:32:36 +0000 Received: from mail-yx0-f177.google.com ([209.85.213.177]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RTC0A-0002fR-31 for linux-arm-kernel@lists.infradead.org; Wed, 23 Nov 2011 12:32:35 +0000 Received: by yenr8 with SMTP id r8so1568857yen.36 for ; Wed, 23 Nov 2011 04:32:31 -0800 (PST) MIME-Version: 1.0 Received: by 10.205.135.129 with SMTP id ig1mr24152800bkc.106.1322051549325; Wed, 23 Nov 2011 04:32:29 -0800 (PST) Received: by 10.223.72.14 with HTTP; Wed, 23 Nov 2011 04:32:29 -0800 (PST) In-Reply-To: <20111122205552.GO27267@pengutronix.de> References: <1321963316-9058-1-git-send-email-javier.martin@vista-silicon.com> <1321963316-9058-3-git-send-email-javier.martin@vista-silicon.com> <20111122205552.GO27267@pengutronix.de> Date: Wed, 23 Nov 2011 13:32:29 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations. From: javier Martin To: Sascha Hauer X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.213.177 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: fabio.estevam@freescale.com, shawn.guo@linaro.org, kernel@pengutronix.de, r.schwebel@pengutronix.de, hverkuil@xs4all.nl, kyungmin.park@samsung.com, laurent.pinchart@ideasonboard.com, s.nawrocki@samsung.com, linux-media@vger.kernel.org, richard.zhao@linaro.org, linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org Hi Sascha, I was just trying to fix the issues you pointed previously and I have a question for you. On 22 November 2011 21:55, Sascha Hauer wrote: > Hi Javier, >> + >> +static int emmaprp_probe(struct platform_device *pdev) >> +{ >> +     struct emmaprp_dev *pcdev; >> +     struct video_device *vfd; >> +     struct resource *res_emma; >> +     int irq_emma; >> +     int ret; >> + >> +     pcdev = kzalloc(sizeof *pcdev, GFP_KERNEL); >> +     if (!pcdev) >> +             return -ENOMEM; >> + >> +     spin_lock_init(&pcdev->irqlock); >> + >> +     pcdev->clk_emma = clk_get(NULL, "emma"); > > You should change the entry for the emma in > arch/arm/mach-imx/clock-imx27.c to the following: > > _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) > > and use clk_get(&pdev->dev, NULL) here. > Is this what you are asking for? If I do that, mx2_camera.c will stop working. Furthermore it does not work for this driver either (I get an error on clk_get() ). --- a/arch/arm/mach-imx/clock-imx27.c +++ b/arch/arm/mach-imx/clock-imx27.c @@ -661,7 +661,7 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK(NULL, "dma", dma_clk) _REGISTER_CLOCK(NULL, "rtic", rtic_clk) _REGISTER_CLOCK(NULL, "brom", brom_clk) - _REGISTER_CLOCK(NULL, "emma", emma_clk) + _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk) _REGISTER_CLOCK(NULL, "slcdc", slcdc_clk) _REGISTER_CLOCK("imx27-fec.0", NULL, fec_clk) _REGISTER_CLOCK(NULL, "emi", emi_clk)