From patchwork Wed Nov 23 12:32:29 2011
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [v2,2/2] MEM2MEM: Add support for eMMa-PrP mem2mem operations.
Date: Wed, 23 Nov 2011 02:32:29 -0000
From: Javier Martin <javier.martin@vista-silicon.com>
X-Patchwork-Id: 127294
Message-Id: <CACKLOr0-GzO0r0ERCQvqCn2oDkDE816+MHsu=bLbA5BkEBAqYA@mail.gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: fabio.estevam@freescale.com, shawn.guo@linaro.org, kernel@pengutronix.de, 
 r.schwebel@pengutronix.de, hverkuil@xs4all.nl, kyungmin.park@samsung.com, 
 laurent.pinchart@ideasonboard.com, s.nawrocki@samsung.com,
 linux-media@vger.kernel.org, richard.zhao@linaro.org,
 linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com

Hi Sascha,
I was just trying to fix the issues you pointed previously and I have
a question for you.

On 22 November 2011 21:55, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> Hi Javier,
>> +
>> +static int emmaprp_probe(struct platform_device *pdev)
>> +{
>> +     struct emmaprp_dev *pcdev;
>> +     struct video_device *vfd;
>> +     struct resource *res_emma;
>> +     int irq_emma;
>> +     int ret;
>> +
>> +     pcdev = kzalloc(sizeof *pcdev, GFP_KERNEL);
>> +     if (!pcdev)
>> +             return -ENOMEM;
>> +
>> +     spin_lock_init(&pcdev->irqlock);
>> +
>> +     pcdev->clk_emma = clk_get(NULL, "emma");
>
> You should change the entry for the emma in
> arch/arm/mach-imx/clock-imx27.c to the following:
>
> _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk)
>
> and use clk_get(&pdev->dev, NULL) here.
>

Is this what you are asking for?


If I do that, mx2_camera.c will stop working.
Furthermore it does not work for this driver either (I get an error on
clk_get() ).


--- a/arch/arm/mach-imx/clock-imx27.c
+++ b/arch/arm/mach-imx/clock-imx27.c
@@ -661,7 +661,7 @@ static struct clk_lookup lookups[] = {
        _REGISTER_CLOCK(NULL, "dma", dma_clk)
        _REGISTER_CLOCK(NULL, "rtic", rtic_clk)
        _REGISTER_CLOCK(NULL, "brom", brom_clk)
-       _REGISTER_CLOCK(NULL, "emma", emma_clk)
+       _REGISTER_CLOCK("m2m-emmaprp", NULL, emma_clk)
        _REGISTER_CLOCK(NULL, "slcdc", slcdc_clk)
        _REGISTER_CLOCK("imx27-fec.0", NULL, fec_clk)
        _REGISTER_CLOCK(NULL, "emi", emi_clk)