Patchwork support LTO of transactional memory

login
register
mail settings
Submitter IainS
Date Nov. 22, 2011, 10:40 p.m.
Message ID <491AB668-D435-4E50-8CDF-41C7259EB360@sandoe-acoustics.co.uk>
Download mbox | patch
Permalink /patch/127180/
State New
Headers show

Comments

IainS - Nov. 22, 2011, 10:40 p.m.
On 22 Nov 2011, at 21:43, Richard Henderson wrote:

> On 11/22/2011 01:37 PM, Jack Howarth wrote:
>> On x86_64-apple-darwin11, this converts the link failures into run- 
>> time failures
>> as are seen on i386 linux.
>
>
> These aren't supposed to be runtime tests.  Did a { dg-do link }  
> marker get missed?

this works for me if that was the intention
Iain
Aldy Hernandez - Nov. 22, 2011, 10:42 p.m.
On 11/22/11 16:40, Iain Sandoe wrote:
>
> On 22 Nov 2011, at 21:43, Richard Henderson wrote:
>
>> On 11/22/2011 01:37 PM, Jack Howarth wrote:
>>> On x86_64-apple-darwin11, this converts the link failures into
>>> run-time failures
>>> as are seen on i386 linux.
>>
>>
>> These aren't supposed to be runtime tests. Did a { dg-do link } marker
>> get missed?
>
> this works for me if that was the intention
> Iain
>
>
>

Whoops, that was indeed the intention.  They are link tests, not runtime 
tests.
IainS - Nov. 27, 2011, 2:13 p.m.
On 22 Nov 2011, at 22:42, Aldy Hernandez wrote:

> On 11/22/11 16:40, Iain Sandoe wrote:
>>
>> On 22 Nov 2011, at 21:43, Richard Henderson wrote:
>>
>>> On 11/22/2011 01:37 PM, Jack Howarth wrote:
>>>> On x86_64-apple-darwin11, this converts the link failures into
>>>> run-time failures
>>>> as are seen on i386 linux.
>>>
>>>
>>> These aren't supposed to be runtime tests. Did a { dg-do link }  
>>> marker
>>> get missed?
>>
>> this works for me if that was the intention
>
> Whoops, that was indeed the intention.  They are link tests, not  
> runtime tests.

applied thus:
http://gcc.gnu.org/ml/gcc-cvs/2011-11/msg01060.html
Iain

Patch

Index: gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c
===================================================================
--- gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c	(revision 181634)
+++ gcc/testsuite/gcc.dg/lto/trans-mem-2_0.c	(working copy)
@@ -1,4 +1,5 @@ 
 /* { dg-lto-options {{-flto -fgnu-tm}} } */
+/* { dg-lto-do link } */
 
 extern void foobar() __attribute__((transaction_callable));
 
@@ -9,6 +10,8 @@  dummy(_ITM_beginTransaction)
 dummy(_ITM_commitTransaction)
 dummy(_ITM_WU4)
 dummy(_ITM_WU8)
+dummy(_ITM_registerTMCloneTable)
+dummy(_ITM_deregisterTMCloneTable)
 
 main()
 {
Index: gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c
===================================================================
--- gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c	(revision 181634)
+++ gcc/testsuite/gcc.dg/lto/trans-mem-1_0.c	(working copy)
@@ -1,4 +1,5 @@ 
 /* { dg-lto-options {{-flto -fgnu-tm}} } */
+/* { dg-lto-do link } */
 
 int i;
 
Index: gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c
===================================================================
--- gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c	(revision 181634)
+++ gcc/testsuite/gcc.dg/lto/trans-mem-1_1.c	(working copy)
@@ -5,3 +5,5 @@  dummy(_ITM_beginTransaction)
 dummy(_ITM_commitTransaction)
 dummy(_ITM_WU4)
 dummy(_ITM_WU8)
+dummy(_ITM_registerTMCloneTable)
+dummy(_ITM_deregisterTMCloneTable)