From patchwork Tue Nov 22 21:30:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 127175 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 2CFFCB7105 for ; Wed, 23 Nov 2011 08:30:43 +1100 (EST) Received: (qmail 13747 invoked by alias); 22 Nov 2011 21:30:42 -0000 Received: (qmail 13738 invoked by uid 22791); 22 Nov 2011 21:30:41 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 21:30:25 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAMLUNHC031351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Nov 2011 16:30:23 -0500 Received: from houston.quesejoda.com (vpn-8-164.rdu.redhat.com [10.11.8.164]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pAMLUMSg016831; Tue, 22 Nov 2011 16:30:22 -0500 Message-ID: <4ECC146E.2080304@redhat.com> Date: Tue, 22 Nov 2011 15:30:22 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Iain Sandoe CC: Jack Howarth , Richard Henderson , gcc-patches , Andrew Pinski Subject: Re: [patch] support LTO of transactional memory References: <4ECAA72B.90409@redhat.com> <4ECAAA6A.7020805@redhat.com> <4ECBE217.7080808@redhat.com> <4ECBEA54.4000103@redhat.com> <20111122205722.GA21689@bromo.med.uc.edu> <4ECC0F95.3020400@redhat.com> <885143B9-90F9-4B36-89DE-288C15AF3B88@sandoe-acoustics.co.uk> In-Reply-To: <885143B9-90F9-4B36-89DE-288C15AF3B88@sandoe-acoustics.co.uk> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > It's a consequence of a combination of the way that "weak" works on > Darwin, and the fact that I tried to make a "one size fits all" crt. > >> >> Can you try this? >> > > we will need a dummy for _ITM_deregisterTMCloneTable as well. Then try this; similarly for any other symbols Darwin may be generating. Feel free to commit as obvious, or just let me know if it works and I can commit. testsuite/ * gcc.dg/lto/trans-mem-2_0.c: Add _ITM_*registerTMCloneTable dummy. * gcc.dg/lto/trans-mem-1_1.c: Add _ITM_*registerTMCloneTable dummy. Index: testsuite/gcc.dg/lto/trans-mem-2_0.c =================================================================== --- testsuite/gcc.dg/lto/trans-mem-2_0.c (revision 181629) +++ testsuite/gcc.dg/lto/trans-mem-2_0.c (working copy) @@ -9,6 +9,8 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable) +dummy(_ITM_deregisterTMCloneTable) main() { Index: testsuite/gcc.dg/lto/trans-mem-1_1.c =================================================================== --- testsuite/gcc.dg/lto/trans-mem-1_1.c (revision 181629) +++ testsuite/gcc.dg/lto/trans-mem-1_1.c (working copy) @@ -5,3 +5,5 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable) +dummy(_ITM_deregisterTMCloneTable)