From patchwork Tue Nov 22 21:09:41 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 127170 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 3BEA7B6FA2 for ; Wed, 23 Nov 2011 08:10:11 +1100 (EST) Received: (qmail 3852 invoked by alias); 22 Nov 2011 21:10:06 -0000 Received: (qmail 3843 invoked by uid 22791); 22 Nov 2011 21:10:05 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 21:09:45 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pAML9hSt024024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 22 Nov 2011 16:09:43 -0500 Received: from houston.quesejoda.com (vpn-8-164.rdu.redhat.com [10.11.8.164]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id pAML9f2M009974; Tue, 22 Nov 2011 16:09:42 -0500 Message-ID: <4ECC0F95.3020400@redhat.com> Date: Tue, 22 Nov 2011 15:09:41 -0600 From: Aldy Hernandez User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20110930 Thunderbird/7.0.1 MIME-Version: 1.0 To: Iain Sandoe CC: Jack Howarth , Richard Henderson , gcc-patches , Andrew Pinski Subject: Re: [patch] support LTO of transactional memory References: <4ECAA72B.90409@redhat.com> <4ECAAA6A.7020805@redhat.com> <4ECBE217.7080808@redhat.com> <4ECBEA54.4000103@redhat.com> <20111122205722.GA21689@bromo.med.uc.edu> In-Reply-To: Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org >> -fgnu-tm -m32 -o gcc-dg-lto-trans-mem-1-01.exe (timeout = 300) >> Undefined symbols for architecture i386:^M >> "__ITM_registerTMCloneTable", referenced from:^M >> ___doTMRegistrations in crttms.o^M >> ___doTMRegistrations in crttms.o^M >> "__ITM_deregisterTMCloneTable", referenced from:^M >> ___doTMdeRegistrations in crttme.o^M >> ___doTMdeRegistrations in crttme.o^M >> ld: symbol(s) not found for architecture i386^M >> collect2: error: ld returned 1 exit status^M >> compiler exited with status 1 >> output is: >> Undefined symbols for architecture i386:^M >> "__ITM_registerTMCloneTable", referenced from:^M >> ___doTMRegistrations in crttms.o^M >> ___doTMRegistrations in crttms.o^M "__ITM_deregisterTMCloneTable", >> referenced from:^M >> ___doTMdeRegistrations in crttme.o^M >> ___doTMdeRegistrations in crttme.o^M >> ld: symbol(s) not found for architecture i386^M >> collect2: error: ld returned 1 exit status^M >> >> FAIL: gcc.dg/lto/trans-mem-1 >> c_lto_trans-mem-1_0.o-c_lto_trans-mem-1_1.o link, -flto -fgnu-tm > > I think we will need to ensure that libitm.dylib is on the link line - > - maybe we're not picking up the spec properly.... This is a missing dummy declaration for the test, since we're not linking with libitm. On Linux x86-64 there was no call to _ITM_registerTMCloneTable generated by the compiler. Can you try this? testsuite/ * gcc.dg/lto/trans-mem-2_0.c: Add _ITM_registerTMCloneTable dummy. * gcc.dg/lto/trans-mem-1_1.c: Add _ITM_registerTMCloneTable dummy. Index: testsuite/gcc.dg/lto/trans-mem-2_0.c =================================================================== --- testsuite/gcc.dg/lto/trans-mem-2_0.c (revision 181629) +++ testsuite/gcc.dg/lto/trans-mem-2_0.c (working copy) @@ -9,6 +9,7 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable) main() { Index: testsuite/gcc.dg/lto/trans-mem-1_1.c =================================================================== --- testsuite/gcc.dg/lto/trans-mem-1_1.c (revision 181629) +++ testsuite/gcc.dg/lto/trans-mem-1_1.c (working copy) @@ -5,3 +5,4 @@ dummy(_ITM_beginTransaction) dummy(_ITM_commitTransaction) dummy(_ITM_WU4) dummy(_ITM_WU8) +dummy(_ITM_registerTMCloneTable)