Patchwork slub: Lockout validation scans during freeing of object

login
register
mail settings
Submitter Christoph Lameter
Date Nov. 22, 2011, 7:46 p.m.
Message ID <alpine.DEB.2.00.1111221340320.30368@router.home>
Download mbox | patch
Permalink /patch/127154/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Christoph Lameter - Nov. 22, 2011, 7:46 p.m.
On Tue, 22 Nov 2011, Markus Trippelsdorf wrote:

> > Could you get me the value of the "slabs" field for the slabs showing the
> > wierd values. I.e. do
> >
> > cat /sys/kernel/slab/signal_cache/slabs
> >
> > > signal_cache               268     920   360.4K 18446744073709551614/7/24   17 2  31  68 A
> >
>
> It's quite easy to explain. You're using unsigned ints in:
> snprintf(dist_str, 40, "%lu/%lu/%d", s->slabs - s->cpu_slabs, s->partial, s->cpu_slabs);
>
> and  (s->slabs - s->cpu_slabs) can get negative. For example:
>
> task_struct                269    1504   557.0K 18446744073709551601/5/32   21 3  29  72
>
> Here s-slabs is 17 and s->cpu_slabs is 32.
> That gives: 17-32=18446744073709551601.

s->cpu_slabs includes the number of per cpu partial slabs since 3.2. And
that calculation is broken it seems. It adds up the number of objects instead
of the number of slab pages.

So much for review and having that stuff in -next for a long time. Sigh.


Subject: slub: Fix per cpu partial statistics

Support for SO_OBJECTS was not properly added to show_slab_objects().

If SO_OBJECTS is not set then the number of slab pages needs to be
returned not the number of objects in the partial slabs.
We do not have that number so just return 1 until we find a better
way to determine that.

Signed-off-by: Christoph Lameter <cl@linux.com>

---
 mm/slub.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: linux-2.6/mm/slub.c
===================================================================
--- linux-2.6.orig/mm/slub.c	2011-11-22 13:42:23.000000000 -0600
+++ linux-2.6/mm/slub.c	2011-11-22 13:43:56.000000000 -0600
@@ -4451,7 +4451,7 @@  static ssize_t show_slab_objects(struct
 				continue;

 			if (c->page) {
-					if (flags & SO_TOTAL)
+				if (flags & SO_TOTAL)
 						x = c->page->objects;
 				else if (flags & SO_OBJECTS)
 					x = c->page->inuse;
@@ -4464,7 +4464,11 @@  static ssize_t show_slab_objects(struct
 			page = c->partial;

 			if (page) {
-				x = page->pobjects;
+				if (flags & SO_OBJECTS)
+					x = page->pobjects;
+				else
+					/* Assume one */
+					x = 1;
                                 total += x;
                                 nodes[c->node] += x;
 			}