| Message ID | 1321962970-2876-1-git-send-email-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Tue, 22 Nov 2011, Markus Armbruster wrote: > Falls through to 32 bpp. Harmless, because the only difference is the > alpha component, and we're not using that. Spotted by Coverity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> ack > console.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/console.c b/console.c > index ce0429d..223f8fd 100644 > --- a/console.c > +++ b/console.c > @@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp) > pf.rbits = 8; > pf.gbits = 8; > pf.bbits = 8; > + break; > case 32: > pf.rmask = 0x00FF0000; > pf.gmask = 0x0000FF00; > -- > 1.7.6.4 > >
On Tue, Nov 22, 2011 at 12:56:10PM +0100, Markus Armbruster wrote: > Falls through to 32 bpp. Harmless, because the only difference is the > alpha component, and we're not using that. Spotted by Coverity. > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > console.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied to the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches-next Stefan
diff --git a/console.c b/console.c index ce0429d..223f8fd 100644 --- a/console.c +++ b/console.c @@ -1688,6 +1688,7 @@ PixelFormat qemu_default_pixelformat(int bpp) pf.rbits = 8; pf.gbits = 8; pf.bbits = 8; + break; case 32: pf.rmask = 0x00FF0000; pf.gmask = 0x0000FF00;
Falls through to 32 bpp. Harmless, because the only difference is the alpha component, and we're not using that. Spotted by Coverity. Signed-off-by: Markus Armbruster <armbru@redhat.com> --- console.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)