From patchwork Tue Nov 22 08:52:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: hkran X-Patchwork-Id: 127019 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4067B1007D2 for ; Tue, 22 Nov 2011 19:52:41 +1100 (EST) Received: from localhost ([::1]:41684 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSm5j-0002qy-65 for incoming@patchwork.ozlabs.org; Tue, 22 Nov 2011 03:52:35 -0500 Received: from eggs.gnu.org ([140.186.70.92]:47868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSm5d-0002qT-0z for qemu-devel@nongnu.org; Tue, 22 Nov 2011 03:52:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RSm5c-00018U-2H for qemu-devel@nongnu.org; Tue, 22 Nov 2011 03:52:28 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:54817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RSm5b-00018J-GB for qemu-devel@nongnu.org; Tue, 22 Nov 2011 03:52:28 -0500 Received: from /spool/local by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Nov 2011 08:50:38 +1000 Received: from d23relay03.au.ibm.com ([202.81.31.245]) by e23smtp08.au.ibm.com ([202.81.31.205]) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 22 Nov 2011 08:50:37 +1000 Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pAM8q7FK4509890 for ; Tue, 22 Nov 2011 19:52:07 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pAM8q7Mn008521 for ; Tue, 22 Nov 2011 19:52:07 +1100 Received: from oc0100708617.ibm.com ([9.115.118.207]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id pAM8q6rv008438; Tue, 22 Nov 2011 19:52:06 +1100 Message-ID: <4ECB62B5.6040108@linux.vnet.ibm.com> Date: Tue, 22 Nov 2011 16:52:05 +0800 From: hkran User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Red Hat/3.1.11-2.el6_1 Thunderbird/3.1.11 MIME-Version: 1.0 To: qemu-devel x-cbid: 11112122-5140-0000-0000-0000004B6370 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 202.81.31.141 Cc: hkran , Stefan Hajnoczi , Gerd Hoffmann Subject: [Qemu-devel] [PATCH] Implement the function usb_hub_handle_reset X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Implement the function usb_hub_handle_reset. without it the guest propablly fail to configure the usb device attached to the virtulized hub with a correct address. Typically, attaching more than one usb devices when lauch qemu may lead to the problem. Signed-off-by: hkran --- hw/usb-hub.c | 13 ++++++++++++- 1 files changed, 12 insertions(+), 1 deletions(-) static int usb_hub_handle_control(USBDevice *dev, USBPacket *p, diff --git a/hw/usb-hub.c b/hw/usb-hub.c index 3eb0f1a..6731075 100644 --- a/hw/usb-hub.c +++ b/hw/usb-hub.c @@ -220,7 +220,18 @@ static void usb_hub_complete(USBPort *port, USBPacket *packet) static void usb_hub_handle_reset(USBDevice *dev) { - /* XXX: do it */ + USBHubPort *port = NULL; + USBHubState *s = (USBHubState *)dev; + int i; + + for(i = 0; i < NUM_PORTS; i++) { + port = &(s->ports[i]); + if(port->wPortStatus & PORT_STAT_CONNECTION) { + usb_reset(&port->port); + port->wPortStatus = PORT_STAT_CONNECTION | PORT_STAT_POWER; + port->wPortChange = PORT_STAT_C_CONNECTION; + } + } }