From patchwork Tue Nov 22 07:42:20 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 127009 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 1535A1007D2 for ; Tue, 22 Nov 2011 18:42:42 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754379Ab1KVHmd (ORCPT ); Tue, 22 Nov 2011 02:42:33 -0500 Received: from mail-gx0-f174.google.com ([209.85.161.174]:39736 "EHLO mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754349Ab1KVHmc (ORCPT ); Tue, 22 Nov 2011 02:42:32 -0500 Received: by ggnr5 with SMTP id r5so3246676ggn.19 for ; Mon, 21 Nov 2011 23:42:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:subject:from:to:cc:date:content-type:x-mailer :content-transfer-encoding:mime-version; bh=8MIpXLCkILN533jcsOybR0x0sjnQmGOAjXCbanNpOI8=; b=X1pZYSvJD0Azz1Ta9MNLjsf5qvIDRBkLNzf52ZH81jJpnWI+gTjwbkt50oToUQPeYr 0g6NjsUv87u4fA8EblwG1YCObzyWheMfC2TKTZaAIVK3zEZhNYKo2pcpU+42UTG4KDtR GkVCa7my5q7jTFaYD8HCcTQdkT1nocLHj9y/s= Received: by 10.236.184.199 with SMTP id s47mr16843411yhm.94.1321947752215; Mon, 21 Nov 2011 23:42:32 -0800 (PST) Received: from [218.172.232.140] (218-172-232-140.dynamic.hinet.net. [218.172.232.140]) by mx.google.com with ESMTPS id 36sm2918600anz.2.2011.11.21.23.42.28 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Nov 2011 23:42:30 -0800 (PST) Message-ID: <1321947740.2476.0.camel@phoenix> Subject: [PATCH] bbc_i2c: Remove unneeded err variable From: Axel Lin To: linux-kernel@vger.kernel.org Cc: "David S. Miller" , sparclinux@vger.kernel.org Date: Tue, 22 Nov 2011 15:42:20 +0800 X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 Sender: sparclinux-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: sparclinux@vger.kernel.org Signed-off-by: Axel Lin --- drivers/sbus/char/bbc_i2c.c | 14 ++++---------- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/sbus/char/bbc_i2c.c b/drivers/sbus/char/bbc_i2c.c index 5f94d22..a0d1399 100644 --- a/drivers/sbus/char/bbc_i2c.c +++ b/drivers/sbus/char/bbc_i2c.c @@ -233,13 +233,9 @@ int bbc_i2c_write_buf(struct bbc_i2c_client *client, int ret = 0; while (len > 0) { - int err = bbc_i2c_writeb(client, *buf, off); - - if (err < 0) { - ret = err; + ret = bbc_i2c_writeb(client, *buf, off); + if (ret < 0) break; - } - len--; buf++; off++; @@ -253,11 +249,9 @@ int bbc_i2c_read_buf(struct bbc_i2c_client *client, int ret = 0; while (len > 0) { - int err = bbc_i2c_readb(client, buf, off); - if (err < 0) { - ret = err; + ret = bbc_i2c_readb(client, buf, off); + if (ret < 0) break; - } len--; buf++; off++;