diff mbox

[1/5] atm: br2684: Do not move counters backwards

Message ID 1321907158-27857-2-git-send-email-jorge@dti2.net
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Jorge Boncompte [DTI2] Nov. 21, 2011, 8:25 p.m. UTC 
From: "Jorge Boncompte [DTI2]" <jorge@dti2.net>

    This snippet has caused several bugs in the past, and I don't see the
point on substracting the skb len from netdev stats.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
---
 net/atm/br2684.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)
diff mbox

Patch

diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index d07223c..81cf33b 100644
--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -557,15 +557,8 @@  static int br2684_regvcc(struct atm_vcc *atmvcc, void __user * arg)
 	skb_queue_splice_init(rq, &queue);
 	spin_unlock_irqrestore(&rq->lock, flags);
 
-	skb_queue_walk_safe(&queue, skb, tmp) {
-		struct net_device *dev;
-
+	skb_queue_walk_safe(&queue, skb, tmp)
 		br2684_push(atmvcc, skb);
-		dev = skb->dev;
-
-		dev->stats.rx_bytes -= skb->len;
-		dev->stats.rx_packets--;
-	}
 
 	/* initialize netdev carrier state */
 	if (atmvcc->dev->signal == ATM_PHY_SIG_LOST)